CRAFTBOOK-2919 - Reported by Sharidan

CraftBook build 3640, running on spigot.

When sitting in a boat and shooting it with bow & arrow, two boats are placed in the inventory. Is it item duplication or caused by configuration?

Configuration for boats is as follows:

boat:
    drops:
        enable: true
    remove-on-exit:
        enable: true
        give-item: true
    land-boats:
        enable: false
    remove-entities:
        enable: false
        remove-other-boats: false
    speed-modifiers:
        enable: false
        max-speed: 0.4
        unnoccupied-deceleration: -1.0
        occupied-deceleration: 0.2
    uncrashable:
        enable: true
    water-place-only:
        enable: true

Comment by me4502

If you disable give item in the remove on exit mechanic, does it still occur? That will check to see if its due to that mech.

Comment by Sharidan

I'll run that through a test during next maintenance run in roughly 10 hours and then report back to you. Thanks.

Comment by Sharidan

remove-on-exit: give-item: false

When shooting the boat using bow and arrow, the boat popped and was returned to inventory. In all other cases no boat was returned. No duplicates were given.

Comment by me4502

Hmm, in that case, it seems that something else is causing the boat to return to your inventory when broken with an arrow. What other plugins do you have?
This doesn't seem to be a craftbook bug in this case, but rather another plugin performing the same functionality at the same time.

Comment by Sharidan

Hmmm. Afaik Essentials doesnt manipulate boats. Other than that maybe mcMMO. We have ProtocolLib on there for some of the craftbook features to function, but other than that the rest of it is economy and town/zone protection stuff, voxelsniper for our builders, WE & WG. I can't really think of any of our plugins that might manipulate boats, except for craftbook.

Comment by me4502

Check the configurations for those plugins, it may be a feature of them. I am checking the CraftBook code to make sure nothing else does the same thing.

Comment by me4502

I didn't find something in CraftBook that could be doing that, but I believe I may have made it not drop if it already has, depending on how the plugin that is causing it works.
Try this build:
http://builds.enginehub.org/job/craftbook/4329/download/craftbook-3.8-SNAPSHOT.zip

Comment by Sharidan

I've spent most of the weekend going through every single plugin we are running with, to try to pinpoint if one of them is causing it, but alas: I came up empty. I will give it a shot with the build you have linked here. Thank you very much for all the assistance :)