DeathTpPlus

DeathTpPlus

229k Downloads

Refactor / Rewrite the Code a bit more

dredhorse opened this issue ยท 7 comments

commented

Mainly need to look at the Tomb and Tombstone implementation and if the packages are really worthwhile.
I don't know if the splitting of the events and listeners really makes sense.
Moving the methods and codes of Tomb and TombStone into helper classes would probably make more sense.

commented

ok. as soon as the helperclasses are done I need to implement them to make config changes easier.

Also a lot of the code needs to be moved into helper classes (Perhaps even static ones), for example. can teleport, teleport position, chargeing etc.

Also perhaps redo the config and choose different words for the options, as like this:

http://forums.bukkit.org/threads/tp-chat-deathtpplus-v-3-8-0-1818-deathnotify-deathtp-tombstones-tomb-and-more-1818.40055/page-9#post-969196

that also need to be coded in a way that it autoupdates the config...Version 4.0 here we come

commented

mung3r this SHOULD NOT be done by you... but any comment? I don't have an email so I can't contact you otherwise :-)

commented

Heh, I honestly forgot why this is assigned to me. It's probably just a mistake.

commented

well... I assigned it to you to get your attention ;-)

so feel free to add anything in here what should change.. I will do the config stuff, after that perhaps we could divide the workload if you want.

commented

Ah, ok. Things are making more sense now :) Maybe separate packages? Something like:

org.simiancage.DeathTpPlus
org.simiancage.TombStone
org.simiancage.Common

What do you think? Sorry I've been inactive. Work is taking a lot of my free time lately.

commented

no probs... I appreciate any help.

yeah that looks good, it should go perhaps together with the renaming to make it more clear, perhaps even divide deathtpplus into deathtp, the messaging and the deathsign.

The new event system should make it quite easy to divide the listeners for the different packages.

We should takle that after I did redo the config class, I'm almost done with the HelperClasses but I found some issues (which where probably obvious for a good coder but sigh...) I need to fix that and than we should be able to use that. I think it will make the config a lot easier, even keeping with the style we have atm.

BTW: perhaps you have an idea about this: http://forums.bukkit.org/threads/location-to-chunk-conversion-issues.61181

it is driving me crazy

commented

ok. I will create a new branch for this after we have released 3.9.0.R5.

I will give the ok after I implemented the HelperClasses, from than onwards it would be cool if you could push a commit which shows the new layout and than we just have to divide the work a little. I will create more issues for that.