DeathTpPlus

DeathTpPlus

229k Downloads

4. Design new Code Structure

dredhorse opened this issue · 4 comments

commented

Ok... ideas about the new structure should go in here:

org.simiancage.DeathTpPlus
org.simiancage.TombStone
org.simiancage.Common

also I think we should move the announcements out of DeathTp, so more like this:

org.simiancage.DeathTp
org.simiancage.Announcements
org.simiancage.TombStone
org.simiancage.Common

I will update this first post with new information.

commented

Created a "refactor" branch and organized the code as follows:

org.simiancage.DeathTp.common
org.simiancage.DeathTp.death
org.simiancage.DeathTp.events // for backward compatibility
org.simiancage.DeathTp.teleport
org.simiancage.DeathTp.tomb

I still have yet to sort out announcements. It wasn't clear to me how to separate that into its own package.

commented

looks very nice...

so do you really want to keep the death messages in here for the spout version? I already have them in MessageChanger (as it changes the default messages ... also death messages).

do we want to keep my strange approach on versioning and checking version numbers and autoupdating the config files?

I also think that I have solved with the help of admin commands UTF helpers the problem of reading and writing messages with äöü and so on... not 100% sure yet though

commented

This round of restructuring is done.

commented

thanks for the nice work you have done