Localize messages to Japanese

Question

Localize messages to Japanese

Scarsz opened this issue 8 years ago · 19 comments

Scarsz commented 8 years ago

639-1 code is ja, need to modify util/LangUtil.java & add appropriate resource files

Only Japanese person I know is @ucchyocean, he implemented LunaChatHook so he'll probably be able to help out with this as his userbase coincides with ours as far as Japanese users go

ucchyocean · Answer 1 · 2017-03-20T01:59:39.000Z

Hi @Scarsz ,
OK, I understood. Leave it to me.

Scarsz · Answer 2 · 2017-03-21T19:21:52.000Z

Any ETA for this @ucchyocean?

ucchyocean · Answer 3 · 2017-03-21T21:43:29.000Z

I will send PR, today or tomorrow.

ucchyocean · Answer 4 · 2017-03-23T21:24:23.000Z

Here.

2017-03-24-1.zip

Scarsz · Answer 5 · 2017-03-23T22:24:09.000Z

#143

I'll investigate the loading issues, seems to just be a problem with SnakeYAML and Japanese characters or something

Scarsz · Answer 6 · 2017-03-23T22:47:50.000Z

@ucchyocean Japanese translations seem to work fine for me, can't reproduce your issue

[Thu, 23. Mar 2017 15:45:07 INFO] [DiscordSRV] チャットプラグインへの接続は一つもありません
[Thu, 23. Mar 2017 15:45:07 INFO] [DiscordSRV] 色: {3498DB=, 71368A=, 95A5A6=, AD1457=, 11806A=, 206694=, 1ABC9C=, 992D22=, E67E22=, A84300=, E74C3C=, 2ECC71=, 979C9F=, 607D8B=, 99AAB5=, F1C40F=, 1F8B4C=, E91E63=, 9B59B6=, C27C0E=, 546E7A=}

ucchyocean · Answer 7 · 2017-03-24T00:19:11.000Z

Oh, really?!
In my Windows10 environment, I cannot load it yet.
Which OS did you use when checking a reproduction confirmation? Windows, Macintosh, or Linux?

Scarsz · Answer 8 · 2017-03-24T00:20:43.000Z

Windows 10 (English language, LangUtil forced to initialize as Japanese)

…

On Thu, Mar 23, 2017 at 5:19 PM うっちぃ ***@***.***> wrote: Oh, really?! In my Windows10 environment, I cannot load it yet. Which OS did you use when checking a reproduction confirmation? Windows, Macintosh, or Linux? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#140 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHVe1OzH7SJBOxrCc3yBG8Q1fee86DCYks5rowv_gaJpZM4Mh2t6> .

ucchyocean · Answer 9 · 2017-03-23T17:56:02.000Z

Hi @Scarsz ,
I made Japanese translation resource messages.
ucchyocean@79b26c2

But, something wrong. DiscordSRV cannot be loaded on ja_JP environment.
Maybe, DiscordSRV cannot handle UTF-8 encording message resource file for now.
I have to do some debug before send PR.

Scarsz · Answer 10 · 2017-03-23T18:19:41.000Z

Any error to go with?

ucchyocean · Answer 11 · 2017-03-24T00:55:56.000Z

Thanks.

Is it an issue specific to my environment?
I will ask other Japanese developers to do the test as well.

Scarsz · Answer 12 · 2017-03-24T01:20:29.000Z

Specific to your environment? Don't know but I have a strong feeling that it's not. Maybe you were running an outdated dev build of DiscordSRV?

Definitely ask other Japanese developers to test the latest dev build though.

ucchyocean · Answer 13 · 2017-03-24T01:33:33.000Z

OK, I see.
I will re-build and re-test it.

Scarsz · Answer 14 · 2017-03-25T03:22:16.000Z

79b26c2
99f9164

ucchyocean · Answer 15 · 2017-03-25T03:24:02.000Z

Oh, your work is very quickly 👍

ucchyocean · Answer 16 · 2017-03-25T03:23:18.000Z

I re-built and re-tested it, but I could not load the plugin correctly yet.

It seems that the plugin is reading the message resource file with ANSI encoding. This hinders internationalization of plugins.

I sent new pull request.
#145
Please review this.

Scarsz · Answer 17 · 2017-03-25T03:24:55.000Z

Go ahead and try the latest snapshot from the build server, http://scarsz.tech:8080/job/DiscordSRV/223/artifact/target/DiscordSRV-Build-13.0-SNAPSHOT-223.jar. If it loads for you, Japanese translations are good to go.

Scarsz · Answer 18 · 2017-03-25T03:33:19.000Z

Good to hear. 😊

ucchyocean · Answer 19 · 2017-03-25T03:32:41.000Z

OK!
I tried 13.0-SNAPSHOT-223. It works correctly!
Thanks.

Share to