DiscordSRV

DiscordSRV

86.8k Downloads

Advancements with "announce-to-chat": false show up in chat (Paper Unaffected)

rcubedev opened this issue ยท 2 comments

commented

Expected behavior

Advancements with "announce-to-chat": false don't appear in Discord.

Actual behavior

Advancements with "announce-to-chat": false are sent to discord
(Does not affect PaperMC)

Steps to reproduce

  1. Download BuildTools
  2. Build latest spigot
  3. Download latest version/snaphot of DiscordSRV
  4. Get a datapack that has an advancement with "announce-to-chat": false
  5. Place DiscordSRV in "plugins" folder.
  6. Place datapack in the datapacks folder (inside the world folder)
  7. Start the server
  8. Configure DiscordSRV
  9. Restart the server
  10. Join
  11. Grant advancement
  12. Advancement shows in Discord

Server software and version

CraftBukkit version 3811-Spigot-c62f4bd-85b89c3 (MC: 1.20.1)

Checks

  • I am not using an outdated version of DiscordSRV.
  • I asked in DiscordSRV's Discord server to see whether this issue is in fact a bug that needs to be fixed.

Anything else

This issue only affects spigot.
(correct me if I am wrong, but it is as DiscordSRV is hooking into the paper advancement api in #1502
add support for Paper advancements api for checking if advancements should be hidden

commented

Was able to reproduce this on Paper as well

commented

Unable to reproduce after fb3294e