EchoPet

EchoPet

882k Downloads

Pets get duped when go though Janus Portal. (BungeeCord)

jameswillis99 opened this issue · 35 comments

commented

Hello,
I have a server and every time someone goes through a portal to another server with their pet their pet gets duped and stays in the portal.
2013-08-13_17 05 40

commented

Theoretically, this issue has been resolved. Re-open this if it's still occurring.

commented

If the player comes back to the original world does it begin to follow again? Or just sit? And the duped Pet is in the second world right?

commented

It just sits there and you get another one of your default pets spawn. If you go through it again another pet gets stuck there. However if you restart the server those pets disappear.

commented

They stay there and as its bungeecord its another server without that plugin so no.

commented

Opps sorry I wondered what close& comment meant :P

commented

I'm slightly confused as well.

commented

I have this same issue with LilyPad when connecting to another server. I dont know what the issue could be, as connecting to another server still throws an onPlayerQuit event

commented

If you use /server (servername) the pet doesn't get duped however when you use the portal it get duped.

commented

As a result of that, I would assume that the Portals don't fire PlayerQuitEvent :/.

commented

I see, I'll do some bugtesting and see if i can figure out the problem..

commented

Same problem, have 1000 pets in my spawn making my server unplayable.

commented

@malverngroup, @ItsHarry, @bobacadodl Pushing out an update as soon as possible. I think I have solved this.

EDIT: Try Build 44 and see if it's fixed yet.

commented

Hello, it seems to be working so far

commented

Awesome.

commented

Nevermind, pets are still being duped.

commented

Well then I'm out for ideas :\

commented

The problem wasn't there in 2.0.6, it started from 2.0.7

commented

Yeah, I've been looking through the commit history to see what has changed, but I haven't noticed anything that would cause this kind of issue.

commented

I'm not sure if it's because of Janus portals, the pets all gather up around the spawn location of my world

commented

Are you able to do some quick testing of the Dev Builds from 2.0.6 (DB30) to 2.0.7 (DB40)? I would but I don't have the portal plugin set up on my test server.

commented

No, I don't know how to reproduce the bug myself, but that would require restarting my server too many times. (There are 1100 people online)

commented

Does anyone know how to reproduce the bug? Is it really Janus portals?

commented

Just taking a stab here...
I think that the Portal might not throw a PlayerQuitEvent, meaning that the Pet is left Owner-less (resulting in it standing still This means that the plugin still thinks the player is online. I'll do some reaearch to see what events the portal actually throws.

commented

Seems quite unlikely to me

commented

It might throw a different event. It could even throw a custom event.

commented

I'm pretty sure BungeeCord sends a disconnect packet upon changing server. Even if that fails, PlayerQuitEvent is always thrown if the connection to a player is lost. Still worth a shot I guess

commented

Just startup a server with a janus portal get a pet and jump through. When you reconnect to the server with pets the pet will be duped.

commented

And in my case will be standing by the portal. And if you want to I could do some testing.

commented

I have the same issue using this http://dev.bukkit.org/bukkit-plugins/portals/ on my hub bungee server

commented

Same issue, with portals + bungeecord server change signs

commented

Same problem - Using AncientGates + BungeeCord

commented

I did some testing recently, and portals DO seem to fire a playerQuitEvent. Not sure what the problem might be. I'll look through the source...

commented

Ah! I have a theory! Portals MIGHT be firing a PlayerTeleportEvent when they redirect the player. In EchoPet's code, it respawns the pets for the player 1 second after they teleport. (even though they are logging out at the same time) That might be the issue. I'll do some more testing..

commented

Anyone tested to see if the above commit fixed this issue?

commented

Will test it when I get back to a PC :)

Sent from my iPhone

On 7 Sep 2013, at 03:47, "DSH105" [email protected] wrote:

Anyone tested to see if the above commit fixed this issue?


Reply to this email directly or view it on GitHub.