EchoPet

EchoPet

882k Downloads

Crashes 1.8 Clients

Yive opened this issue ยท 40 comments

commented

I've got a pet that has a coloured name and well this happened. I don't know if it happens to all mobs, but that is just some details of the mob that is near me when I crashed.
http://i.yive.me/be3e8D1

Server info: build spigot #1631

commented

@DSH105 I seem to be having the same issue when trying to spawn in a cow. Crashes the client.

Spigot 1637. Minecraft 1.8. EchoPets, compiled as of the latest commit 39338fc with WorldGuard 6.0 change in pom.
http://paste.ubuntu.com/8214080/

commented

..

commented

@CaptainBern Not complaining, only informing. :) If DSH doesn't know what broke, he can't start a fix whenever that may be.

commented

It's supposed to break; that's the idea of the modularised structure. Protocol 'hacks' don't help much either :\

commented

LEL

commented
commented

(facepalm) How dumb can server owners be to not realise to disable echopet for a small amount of time.

commented

This is why EchoPet will remain supporting CraftBukkit development builds instead of a pretend 1.8. If it was a 'real' 1.8, EchoPet would disable nicely and it would be easier to fix; no crashes or anything of the sort.

commented

Hopefully dinnerbone and whoever else is working on it, will release it in the next few days so that this plugin can be updated. I miss my Mr Fluffer Muffins :(

commented

That way I can implement Guardian (and armour stand) pets ;D

commented

I have a feeling the armour stands will be slightly creepy when in a dark cave.

commented

It's not so much a "hack" persay... more of a patch. Either way, Protocol Lib has fixes already, just missing citizens and echopets.

commented

EchoPet will remain with 1.7 support until a CraftBukkit 1.8 build is released.

commented

@CaptainBern may have just enlightened me as to where the problem could lie. I'll see if I can push something out soon.

commented

So, after these DMCA takedowns (and the presumption that a 1.8 CraftBukkit will take a bit longer now), has your attitude changed about releasing a working version for the 1.8 protocol hack builds?

commented

Spigot is pretending to be 1.8. It is most certainly not safe for me to publish a release for builds of this nature. So no, sorry :(

commented

I should clarify: not safe for this plugin (mostly as it heavily depends on NMS).

commented

For what it's worth, it's not too hard to make a Spigot-specific version of EchoPet that "fixes" this issue (or at least avoids crashes)

https://github.com/elBukkit/EchoPet/commits/master

Unfortunately, given that the Spigot repo is down, and they are specifically blocking EchoPet, this isn't totally going to help. I have a patch ready for PR (to allow this specific version to run), but nowhere to send a PR to :(

commented

A branch could also work, as you suggested- and then my changes would work out fine. The Spigot build really is 1.7.10, and that is what your plugin detects and uses. The way this works (uses an internal Spigot class) is never going to be cross-compatible with CraftBukkit. I can't see any way to make that work without tying directly into Spigot's protocol hack.

The way I "fixed" Spigot's block was what I described above about adding "spigot" into the MyPets plugin description, and then adding a Spigot patch to allow that version. I think they'd accept it as a PR, if they were able to- but I guess I'm not sure.

-                if ( name.equalsIgnoreCase( "EchoPet" ) )
+                if ( name.equalsIgnoreCase( "EchoPet" ) && !description.getVersion().contains("spigot"))

This is a lot easier than renaming, since renaming the plugin also renames the data folder, servers would lose all their pets config/data without a migration step.

commented

Awesome. It might be worth just having a separate job on the CI for 1.8 Spigot-specific builds when the repo is back up.

commented

Let's hope it comes back up. I handled this by putting "spigot" in the version number, and I have a PR ready for Spigot that will allow just this specific version, to make them happy.

But frankly I've no idea whether or not we can expect these repos to ever come back :(

I'm sure you'd want to break this up in a cleaner way- I just directly modified the 1_7_R4 module, this should probably be in its own Spigot module?

In any case, the actual fix was relatively easy, I'd be happy to submit a PR, but I'm guessing you'd want to re-do this if you were to make it official, anyway.

commented

I have no experience with Spigot, but yes I would like it to still be compatible with 1.7.10, which means another module.

I'll have to rename it to EchoPet-Spigot or ask them to remove the plugin from the blacklist.

commented

Hey NathanWolf. Just writing it in here aswell. I used your fork and as I got no Spigot fork I went ahead and renamed EchoPet and just simply renamed the folder. Works perfectly fine. Cheers man :)

commented

Is there a compiled working version of this online? Like the one of Nathan

commented

There is- but some other devs have been adding their own tweaks and fixes, and we should probably get them all together somewhere.

I think my binary broke zombie pets, and it sounds like there's a particle effect in there that needs to go, crashes Optifine clients.

So I guess.. 'stay tuned'?

commented

The patched version can be downloaded here.
Thank you @NathanWolf for the fix!

commented

Thank you!

commented

The newest spigot patch allows for EchoPet to load again. Just as a headsup for @DSH105 if he wants to distribute a working version on his jenkins

commented

It now crashes people in 1.7 is there a fix to this?

commented

also how do you add another line of lore in the pet select menu

commented

so pigzombie and zombie crashes you if your in 1.7
enderman crashes you in 1.8

commented

Please fix the enderman-crash! Everything else works fine with 1.8-clients. :)

commented

I am getting a crash http://pastebin.com/6jNZ72uq

commented

From my tests both the Endermen and the Zombie crash the client for everyone on the server.

commented

Spurlex- zombies should be ok if you're using the official patch (they were broken in mind - I'm going to remove those DL links now)

@DSH105 I think this may fix Endermen:

elBukkit@cb06ac5

Not fully tested, but it should be the right idea. Hope it helps!

commented

I am getting reports that zombie and pigzombie also crash clients

commented

Yep, having the same issue. Zombie and PigZombie pets are crashing 1.7 clients and enderman crashes 1.8 clients.

commented

Starting to pull together an official EchoPet patch for Spigot 1.8 (likely for a release on DBO) to fix all currently standing issues that have been reported - hopefully I can make it available this weekend once everything has been tested.

commented

Development builds are now available for Spigot 1.8 (and 1.7.10) over on the Jenkins. The only pet which appears to be having problems is the Human pet (for 1.8 clients only). Other than that, most pets are working as they should.

Thanks to @NathanWolf for his knowledge of the Spigot API :D