EchoPet

EchoPet

882k Downloads

Bugs found in snapshot.

dwilson390 opened this issue · 4 comments

commented

Hello, I was able to find the following bugs in build #20 of the EchoPet using latest spigot 1.8 build.

 - Right-clicking a pet does not open it menu.
 - On toggling the 'Hat' option on, the pet covers your face and the player cannot see.
 - If you sprint and jump in water while riding your pet, you no longer are riding the pet.
 - You can lose your pet by flying in the air far away from it. In fact, it appears to despawn.
 - Attempting to spawn a human still crashes the server, on an attempt to relogin, the server crashes again, the only way to stop this that I could see was to remove the pet from pets.yml.
 - When riding your pet, you can go though blocks which if you are in survival, can kill you.
 - When your pet it removed, changed or toggled the smoke does appear. E.g. If I remove my pet chicken it just disappears and no smoke appears (By smoke I mean the particle like things that appear around a nether portal or when you use an eye of ender).

I would like to suggest the following features :)

 - The GUI cloes when you make a change e.g. after changing the colour of your sheep the GUI cloeses.
 - /pet list is very long, would /pet list 2, pet list 3 be possible?

Thanks so much for everything! I hope you will find this post useful! :)

commented

Thanks for helping out! I appreciate you taking the time to test out 1.8 support ;D. Here's a quick breakdown of everything reported:

Right-clicking a pet does not open it menu.

Fixed in bb26c04.

On toggling the 'Hat' option on, the pet covers your face and the player cannot see.

Unfortunately, this is client-side and not something I can easily control :(. I've marked it as 'known issues that cannot be fixed' over on ticket #446.

If you sprint and jump in water while riding your pet, you no longer are riding the pet.

According to this closed report on the Mojang JIRA, this behaviour is intentional. I'm not entirely sure why this behaviour occurs with pets, but considering the underlying EchoPet implementation for pet riding is very similar to the normal NMS horse, it's probably related.

You can lose your pet by flying in the air far away from it. In fact, it appears to despawn.

I've had reports of this before, but still have no way to fix it yet. The in-dev v3 infrastructure might deal with this differently, but I'm not going to pull it apart to find out where this can be solved in v2 (seeing as v3 will likely [hopefully] be released alongside the upcoming Sponge platform).

Attempting to spawn a human still crashes the server, on an attempt to relogin, the server crashes again, the only way to stop this that I could see was to remove the pet from pets.yml.

Not sure as of yet if 1.8 supports human pets in the way they're implemented in EchoPet. Related commits (from #446):

  • 67444aa
  • As per 410f879, human pets no longer crash the server. They do, however, appear as zombies (which I don't currently have a fix for yet).

When riding your pet, you can go though blocks which if you are in survival, can kill you.

This bug has been around for a while and I still haven't implemented a proper solution yet :.

When your pet it removed, changed or toggled the smoke does appear. E.g. If I remove my pet chicken it just disappears and no smoke appears (By smoke I mean the particle like things that appear around a nether portal or when you use an eye of ender).

Particles are temporarily disabled until I fixed them. Glad you noticed they were gone though :3.

The GUI cloes when you make a change e.g. after changing the colour of your sheep the GUI cloeses.

The GUI is designed to be an easy-access way of modifying pet attributes successively (especially useful for pets with quite a few attributes). I'm interested in whether the majority of users would prefer it to close than the implementation currently in place. I might place a poll on the DBO page regarding this.

/pet list is very long, would /pet list 2, pet list 3 be possible?

Sure! Instead of pages though, I've gone ahead and modified an existing /pet list command from the v3 command set based on the new 1.7 chat protocol features:

List command

That should make the list a bit clearer and easier to read.

Here's a link to the related commits: 97f568e, 137167a.


I'll post comments below if I have any further updates on any of those.

Again, thanks for lending a hand :D

commented

Awesome! Thanks :D As a matter of interest, does this bring us closer to the release date, I'm so inpatient I know ;)

commented

:D so excited! Thanks for all your hard work :)

Sent from my iPod

On 12 Dec 2014, at 7:25 pm, Jason [email protected] wrote:

Sure does! :D

I'll likely be removing human pets and then releasing this afternoon.


Reply to this email directly or view it on GitHub.

commented

Sure does! :D

I'll likely be removing human pets and then releasing this afternoon.