Just a short question regarding a part of your code
scomans opened this issue · 5 comments
While fixing the incompatibility between our two plugins because of the /petadmin command is saw this section:
And was wondering why it looked so similar to mine:
https://github.com/xXKeyleXx/MyPet/blob/master/src/main/java/de/Keyle/MyPet/MyPetPlugin.java#L406-L441
So my question:
Did you copied this (and other parts)/used this (and other parts) as template? It's ok for me but it would be nice to know and maybe get a small note in the code.
Thanks ;)
I noticed that every time I reload the plugin the list of registered entities was longer and longer so I removed them based on the classname. Simple and very successfully 😄
No it's ok for me and you/I don't need to change anything, I just wanted to know 😉 And thanks for the tip with the enderdragon (BTW did you had the backwards flying enderdragon problem too?)
You can not copy everything that is open source 😉 This depends on the license.
Yeah, you know that you can configure the commands but 99% of the users don't even think about this option 😆 and my users are thinking that my plugin isn't working at all 😆 So it had to be fixed so both can run side by side by default.
Yeah, I had some trouble making the EnderDragon fly forwards, especially with the ride fuction. Most of the existing NMS math for the navigation was very useful though.
I tried it three times now I can't figure it out where I have to add the 180° when the pet is following me 😆
I don't want the enderdragon to fly around AND use pathfinder goals... I can't be that hard....
The short answer: yes, I used that method. I noticed it when I was having trouble with entity registration myself, along with people reporting bugs in some conflicts with it. Using what you had seemed to fix the issue quite well.
The rest of the plugin is based off NMS code and structure.
Feel free to create a PR with the necessary adjustments to your liking. Also, you can check out my implementation of the EnderDragon here if you were having trouble. Feel free to use anything there. Open source is open source ;)
EDIT: And just a note on the incompatibility. My commands are configurable anyway 😉