Hi! NPE on villager right click (3.5)

Question

Hi! NPE on villager right click (3.5)

SimSonic opened this issue 10 years ago · 19 comments

SimSonic commented 10 years ago

I'm trying create villager and all is ok but when I right-click on him I see First sentence and them GUI is opening. In console:

bigbeno37 commented 10 years ago

DBO?

bigbeno37 · Answer 1 · 2015-01-08T11:46:05.000Z

I'm getting this issue as well. Randy! We need- no, DEMAND a fix!

Randehh · Answer 2 · 2015-01-08T16:39:39.000Z

Hmm. I'll check this one out.

Randehh · Answer 3 · 2015-01-08T18:43:08.000Z

Should be fixed.
4b4bf7c

bigbeno37 · Answer 4 · 2015-01-09T08:01:06.000Z

At the moment, as we do not have unit tests (something I am currently implementing), we do not have a CI server. However, it is a possibility for the future

SimSonic · Answer 5 · 2015-01-09T08:09:18.000Z

OK, can you upload fixed version to DBO, please? )

SimSonic · Answer 6 · 2015-01-09T08:42:45.000Z

dev.bukkit.org

bigbeno37 · Answer 7 · 2015-01-09T08:43:50.000Z

Paging Mr. Randy

Randehh · Answer 8 · 2015-01-09T09:03:10.000Z

I've sent a version with some fixed bugs to someone else, but here it is if you wanna test it too: https://dl.dropboxusercontent.com/u/2485556/EpicQuest.jar

SimSonic · Answer 9 · 2015-01-09T07:24:59.000Z

Do you have CI server?

SimSonic · Answer 10 · 2015-01-09T10:27:15.000Z

Still the same...

org.bukkit.event.EventException
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:305) ~[Spigot_v1.8_2015-01-06.jar:git-Spigot-e497721-96d09e3]
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[Spigot_v1.8_2015-01-06.jar:git-Spigot-e497721-96d09e3]
    at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [Spigot_v1.8_2015-01-06.jar:git-Spigot-e497721-96d09e3]
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [Spigot_v1.8_2015-01-06.jar:git-Spigot-e497721-96d09e3]
    at net.minecraft.server.v1_8_R1.PlayerConnection.a(PlayerConnection.java:1268) [Spigot_v1.8_2015-01-06.jar:git-Spigot-e497721-96d09e3]
    at net.minecraft.server.v1_8_R1.PacketPlayInUseEntity.a(SourceFile:52) [Spigot_v1.8_2015-01-06.jar:git-Spigot-e497721-96d09e3]
    at net.minecraft.server.v1_8_R1.PacketPlayInUseEntity.a(SourceFile:11) [Spigot_v1.8_2015-01-06.jar:git-Spigot-e497721-96d09e3]
    at net.minecraft.server.v1_8_R1.PacketHandleTask.run(SourceFile:13) [Spigot_v1.8_2015-01-06.jar:git-Spigot-e497721-96d09e3]
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_11]
    at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_11]
    at net.minecraft.server.v1_8_R1.MinecraftServer.z(MinecraftServer.java:683) [Spigot_v1.8_2015-01-06.jar:git-Spigot-e497721-96d09e3]
    at net.minecraft.server.v1_8_R1.DedicatedServer.z(DedicatedServer.java:316) [Spigot_v1.8_2015-01-06.jar:git-Spigot-e497721-96d09e3]
    at net.minecraft.server.v1_8_R1.MinecraftServer.y(MinecraftServer.java:623) [Spigot_v1.8_2015-01-06.jar:git-Spigot-e497721-96d09e3]
    at net.minecraft.server.v1_8_R1.MinecraftServer.run(MinecraftServer.java:526) [Spigot_v1.8_2015-01-06.jar:git-Spigot-e497721-96d09e3]
    at java.lang.Thread.run(Thread.java:745) [?:1.8.0_11]
Caused by: java.lang.NullPointerException
    at randy.questentities.QuestEntity.NextInteraction(QuestEntity.java:78) ~[?:?]
    at randy.listeners.PlayerInteractListener.onPlayerInteractEntity(PlayerInteractListener.java:92) ~[?:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_11]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_11]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_11]
    at java.lang.reflect.Method.invoke(Method.java:483) ~[?:1.8.0_11]
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:301) ~[Spigot_v1.8_2015-01-06.jar:git-Spigot-e497721-96d09e3]
    ... 14 more

Randehh · Answer 11 · 2015-01-09T10:28:37.000Z

Could you recreate the Quest Entity?

SimSonic · Answer 12 · 2015-01-09T10:37:36.000Z

Yes I did it 3-5 times.
/q questentity create Notch Welcome!
Welcome! — initial quest from plugin's config.
right click on villager = the same console error.

Randehh · Answer 13 · 2015-01-09T10:39:04.000Z

Ah, I see. You should reference quests by their file name, not their display name :)

SimSonic · Answer 14 · 2015-01-09T10:47:47.000Z

It's working... Thanks :)

Randehh · Answer 15 · 2015-01-09T10:49:47.000Z

On this topic, I've created a new task for more config checks, as I see more people have trouble with setting up some things. In any case, happy it works now!

Randehh · Answer 16 · 2015-01-09T10:51:00.000Z

The reason why I made it reference the file name is because then the plugin will always keep track of the quest, so you can change whatever you want in the quest while always making it work. It's also the reason for the big quest changing thing!

SimSonic · Answer 17 · 2015-01-09T12:18:35.000Z

I'm trying to use your plugin first time and see some hardness:

For some reason Reset_Time = -1 is not working.
/q reload during quests allows to get many instances of single quest.
somehow killing mobs is shared between all players given quest to kill mobs :)
Villager is not teleporting to his point.

Maybe I do something wrong and I need just more time to find correct usage. I will try tomorrow :)

Another notes:

Maybe quests and quest givers should be in separate files like it is now, but for per-player progress mysql database can be used. I can help with db design and code.
My server is not english speaking so I need possibility to make translation.

Randehh · Answer 18 · 2015-01-09T14:49:35.000Z

Thanks for the reporting the bugs, can you create issues for them?
Also, I have added the suggestions here already: https://trello.com/b/lrlUoJYq/epicquest-suggest-new-ideas-to-be-added-via-pm-on-bukkit
You can vote for what you want first :)

Share to