EpicQuest

EpicQuest

42.2k Downloads

Metrics not working

Randehh opened this issue ยท 17 comments

commented

@bigbeno37 You said it worked, but there's no page on the website and when I compile and run the plugin, it said it can't find the class "org/mcstats/metrics". Is the POM correct?

commented

Apparently the class isn't shaded for some reason.

commented

I've tried some things, but I can't get it to work sadly enough...

commented

sigh time to go work this out

commented

Yes it is :)

commented

I've submitted a pull request. Follow the instructions there and HOPEFULLY it will work. I mean, it works for me :D

commented

Got it working. #44

commented

How did you do it? Did my pull request fix it?

commented

@DarkShimy00 Fixed it. Yours didn't change a lot, you didn't even execute the code to do the Metrics stuff lol.

commented

That's why I'm asking haha

How did you go about fixing it?

commented

You can look at the commit, but I'm not exactly sure what he did.
Anyway, can you look at our comments here too, please? #43

commented

Well for one he enabled metrics :P

commented

I'm talking about you, Ben :p

commented

There was a "pluginmanagement" section.

pluginManagement: is an element that is seen along side plugins. Plugin Management contains plugin elements in much the same way, except that rather than configuring plugin information for this particular project build, it is intended to configure project builds that inherit from this one. However, this only configures plugins that are actually referenced within the plugins element in the children. The children have every right to override pluginManagement definitions.

With a pluginManagement section, the goal "shade" is not linked to the phase "package". If you want to shade, you have to use the command "mvn shade:shade".

When you remove this section, the goal "shade" is linked to the phase "package" which runs before the "install" phase. So you can run "mvn install".

By the way, you declared "metrics" as a dependency but used "metrics-lite" in the code. I fixed that and after, Akumasama changed the code to use the full version (21d98f5).

commented

Damn dude when did you learn this stuff?

commented

@bigbeno37 Did you read our comments on the other commit? I'm sorry, but you really gotta read it.

commented

Haha I read that ages ago man! I understand

commented

Alright, I didn't see you react on that haha, cool cool.