EssentialsX

EssentialsX

2M Downloads

No Tab-prefix with build #462 and up

mfnalex opened this issue ยท 9 comments

commented

Unfortunately, build 462 implemented something wich broke the prefixes in tab while using EssentialsChat. It worked before. I had to switch back to 461 to get it working...

commented
commented

Correct, it defaults to "false"!

Ok, so... My fix was right, (@vemacs please unrevert it)

You were just missing "add-prefix-in-playerlist" because of the update of EssentialsX.

I suggest you to copy and edit the new config, as I did when I switched too: https://github.com/drtshock/Essentials/blob/35388c3b19b691a8551bbc7c30f87969be47214b/Essentials/src/config.yml

commented

Something is wrong behind some Essentials settings (default values, maybe?), if you use "||" (OR) it shows prefixes and suffixes in Tablist even if "add-prefix-in-playerlist: false" and "add-suffix-in-playerlist: false";
if you use "&&" (AND), they seem to get removed anytime...

commented

The Logic behind my fix was right.
If "withPrefix" is false (because "add-prefix-in-playerlist" is false, otherwise is always true), then it doesn't proceed.

With "||" instead, if that is false, then it checks the other value and that is always true, because it's an option that defaults to true and is not documented.

So let's try to understand why you don't have prefixes in tab: This is probably due to the fact you have "add-prefix-in-playerlist: false" or "disablePrefix: true"

commented

An easy solution for everything is to remove the undocumented "disablePrefix" setting (why is it even there?).

commented

neither "disablePrefix" nor "add-prefix-in-playerlist" does appear in my config. I only have "add-prefix-suffix: true" and "change-playerlist: true". Are you sure the correct the name is add-prefix-in-playerlist?

EDIT: it's working with "add-prefix-in-playerlist: true". I don't know why it was not part of my default config, maybe because it was generated with the normal version of essentials. Thanks for your help!

commented

Yes, it is correct. If you don't have it, it defaults to "true".

This is strange because I tested it with both options before sending a Pull Request :/

commented

Yes, it is closed, you don't have to do anything.

I'm just trying to understand why my fix didn't work correctly for you, because basically 7973f54 has reopened my issue.

commented

As I said, I started using "normal" Essentials, then switched to EssentialsX. Maybe the "add-prefix-in-playerlist" option is not included in the original config and defaults to false?