EssentialsX

EssentialsX

2M Downloads

/eco take command does not take money if the balance of the player is equal to the amount in the command

Flavourized opened this issue · 3 comments

commented

Information

Full output of /ess version:

20.08 13:16:50 [Server] INFO CONSOLE issued server command: /ess version
20.08 13:16:50 [Server] INFO Server version: 1.11.2-R0.1-SNAPSHOT git-TacoSpigot-"8aa5e7ec" (MC: 1.11.2)
20.08 13:16:50 [Server] INFO EssentialsX version: 2.15.0.28
20.08 13:16:50 [Server] INFO LuckPerms version: 4.2.23
20.08 13:16:50 [Server] INFO Vault version: 1.6.7-b${env.TRAVIS_BUILD_NUMBER}
20.08 13:16:50 [Server] INFO EssentialsXSpawn version: 2.15.0.28

Server log (upload logs/latest.log to Gist):

20.08 10:27:18 [Server] INFO CONSOLE issued server command: /essentials:eco set flavour 5000
20.08 10:27:18 [Server] INFO DR » You set Flavour's balance to Ⓓ5,000.
20.08 10:27:22 [Server] INFO CONSOLE issued server command: /essentials:bal flavour
20.08 10:27:22 [Server] INFO Balance of Flavour: Ⓓ5,000
20.08 10:27:29 [Server] INFO CONSOLE issued server command: /essentials:eco take flavour 5000
20.08 10:27:29 [Server] INFO DR » Error: Insufficient funds available.

EssentialsX config (upload plugins/Essentials/config.yml to Gist): https://pastebin.com/yDh81dWT

Details

The /eco take command does not take money if the balance of the player is equal to the argument of the command.

commented

Reproduced

[09:31:14] [Server thread/INFO]: CONSOLE issued server command: /ess version
[09:31:14] [Server thread/INFO]: Server version: 1.11.2-R0.1-SNAPSHOT git-Spigot-3fb9445-6e3cec8 (MC: 1.11.2)
[09:31:14] [Server thread/INFO]: EssentialsX version: 2.15.0.28
[09:31:14] [Server thread/INFO]: Vault version: 1.6.7-b${env.TRAVIS_BUILD_NUMBER}

Console

https://gist.github.com/Herdsman45/7ff55f5a76f0da4e82e1eb6a8a6ad2bb

Details

Clean server with above plugins only.
Default config, except "min-money: 0"
Note: leaving "min-money: -10000" works properly, and will return a 0 balance.

commented

Reproduced on EssentialsX 2.15.0.18 (admittedly, this server is not up-to-date).

> eco
[18:32:32 INFO]: CONSOLE issued server command: /eco
[18:32:32 INFO]: Manages the server economy.
[18:32:32 INFO]: /eco <give|take|set|reset> <player> <amount>
> eco set MD678685 30
[18:32:44 INFO]: CONSOLE issued server command: /eco set MD678685 30
[18:32:44 INFO]: You set MD678685's balance to _30.
> eco take MD678685 30
[18:32:50 INFO]: CONSOLE issued server command: /eco take MD678685 30
[18:32:50 INFO]: Error: Insufficient funds available.
> ess version
[18:32:59 INFO]: CONSOLE issued server command: /ess version
[18:32:59 INFO]: Server version: 1.12.2-R0.1-SNAPSHOT git-Paper-1534 (MC: 1.12.2)
[18:32:59 INFO]: EssentialsX version: 2.15.0.18
[18:32:59 INFO]: LuckPerms version: 4.1.38
[18:32:59 INFO]: Vault version: 1.5.6-b49

Edit: the offending line is below; it should be >= 0.

if (money.subtract(amount).compareTo(minBalance) > 0) {

commented

I've pushed bad0272 - could you try updating to version 2.15.0.32 and see if the issue persists?