EssentialsX

EssentialsX

2M Downloads

/baltop not showing op users

ccattell opened this issue · 18 comments

commented

Information

Full output of /ess version:

[21:33:00] [Server thread/INFO]: Server version: 1.14.2-R0.1-SNAPSHOT git-Spigot-01d0f04-b7fea42 (MC: 1.14.2)
[21:33:00] [Server thread/INFO]: EssentialsX version: 2.16.1.167
[21:33:00] [Server thread/INFO]: LuckPerms version: 4.4.25
[21:33:00] [Server thread/INFO]: Vault version: 1.7.2-b107
[21:33:00] [Server thread/INFO]: EssentialsXChat version: 2.16.1.167
[21:33:00] [Server thread/INFO]: EssentialsXSpawn version: 2.16.1.167

Server log:

EssentialsX config:

Details

Description
When running the /baltop command, any players that have given operator status does not show in the list

Steps to reproduce

Expected behavior

Screenshots

L0rd_Aragorn is /op and not in list
image

I then /deop L0rd_Aragorn
image

commented

Related: e9833d1

commented

Related: e9833d1

I dont get it how do I make it so Op balance shows? also even after deop it wont show

commented

So how do i fix it... i have checked the perms and no one has that permission anywhere, so in theory no one should be excluded, right?

commented

you need to negate the permission essentials.balancetop.exclude
do that for your owner/admin rank
it solved the issue i had which was the same as you posted

commented

you need to negate the permission essentials.balancetop.exclude
do that for your owner/admin rank
it solved the issue i had which was the same as you posted

works for everyone but the owner rank

commented
commented

A related problem is that essentials.balancetop.exclude doesn't work for offline players, /baltop shows their balances if they're not on the server.

exclude permission does work if the player is logged in to the server.

Server version: 1.12.2-R0.1-SNAPSHOT git-Bukkit-acbc348 (MC: 1.12.2)
EssentialsX version: 2.17.0.0
LuckPerms version: 4.4.1
Vault version: 1.6.7-b${env.TRAVIS_BUILD_NUMBER}
EssentialsXGeoIP version: 2.17.0.0
EssentialsXChat version: 2.17.0.0
EssentialsXSpawn version: 2.17.0.0

commented

Yes, players not logged in are listed in /baltop even if they have the permission essentials.balancetop.exclude

EDIT: Well, this bit will return false for the permission for offline players. I was always told you can't check permissions for offline players.

private boolean isAuthorizedCheck(final String node) {
    if (base instanceof OfflinePlayer) {
        return false;
    }
commented

So you're saying that if they are online it works, but if they are offline, it doesn't?

commented

This thread helped me fixing this problem!
Thank you guys!

commented

you need to negate the permission essentials.balancetop.exclude
do that for your owner/admin rank
it solved the issue i had which was the same as you posted

ok but how exactly do I negate the permission?

commented

Depends on your permission plugin, we're happy to help you on our Discord so as to not flood this issue, join here: https://discord.gg/PHpuzZS

commented

so i give my admin the essentials.balancetop.exclude perm but they still do not show up on baltop. we even deop them to see if that would work but nope still nothing (but it shows other players and it shows the co owner and hes op its just not showing me the owner and my head admin)

commented

@GreensaPenguin You need to negate the essentials.balancetop.exclude permission, not give it to them.

commented

On Essentials 2.18.2, when you negate essentials.balancetop.exclude, op is still unlisted when offline. AFAIK when excluded players are offline they are listed, op without negated permission is never listed, and op with negated permission is listed when online and unlisted when offline.

When op has negated permission, his balance is included in the total server's balance whether he's online or not. Without negated permission, his balance is not included when online, but excluded when offline.

Related to the exclusion of the offline players: #3004 #3540 #3100 #3641

Will be fixed pending the merge of #3702

commented

Great, thanks for your work!

commented

On Essentials 2.18.2, when you negate essentials.balancetop.exclude, op is still unlisted when offline. AFAIK when excluded players are offline they are listed, op without negated permission is never listed, and op with negated permission is listed when online and unlisted when offline.

When op has negated permission, his balance is included in the total server's balance whether he's online or not. Without negated permission, his balance is not included when online, but excluded when offline.

Related to the exclusion of the offline players: #3004 #3540 #3100 #3641

commented

And you made it false ?
Well that worked for me with my owner rank
And I am also op. Would double check the perms seem like you might have
missed something.

On Mon, Jun 24, 2019 at 11:03 PM mikelatham [email protected]
wrote:

you need to negate the permission essentials.balancetop.exclude
do that for your owner/admin rank
it solved the issue i had which was the same as you posted

works for everyone but the owner rank


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/EssentialsX/Essentials/issues/2581?email_source=notifications&email_token=AI2C5IMLOHU7FFZMX3KHZ2TP4GDGLA5CNFSM4HSXVNK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYO22AI#issuecomment-505261313,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AI2C5ILQ3GSM4TIOF73R2PTP4GDGLANCNFSM4HSXVNKQ
.

How do I make a permission false?