EssentialsX

EssentialsX

2M Downloads

/sell all returns {1} instead of total sold value

AetherisMC-Squid opened this issue ยท 5 comments

commented

Information

Full output of /ess version:

>.... [05:27:29 INFO]: Server version: 1.16.2-R0.1-SNAPSHOT git-Paper-184 (MC: 1.16.2)
>.... [05:27:29 INFO]: EssentialsX version: 2.18.1.3
>.... [05:27:29 INFO]: PlaceholderAPI version: 2.10.9
>.... [05:27:29 INFO]: LuckPerms version: 5.1.98
>.... [05:27:29 INFO]: Vault version: 1.7.3-b131
>.... [05:27:29 INFO]: EssentialsXProtect version: 2.18.1.3
>.... [05:27:29 INFO]: EssentialsXSpawn version: 2.18.1.3
>.... [05:27:29 INFO]: ChestShop version: 3.11 (build 213)

Server log: Not necessary (If needed please ask)

EssentialsX config: https://gist.github.com/EtherealSquid/39c7f4e612bfde2cf837be07b2716d59

Details

Description
When using /sell all to sell all items, the total sold worth is reported as the placeholder {1} instead of the running total.

Steps to reproduce

  1. Have multiple sellable items in your inventory.
  2. /sell all.

Expected behavior
When selling all items, the total worth of all sales should be added up and reported as a lump sum at the bottom of the returned text for the transaction.

Screenshots

image
image

commented

Are you using custom locale?

commented

Can confirm with latest build, fix was changing {1} to {0}.

commented

Does that mean that {1} needs to be changed to {0} in every single locale?

commented

Eh, not the most ideal. Best bet is probably adding the useless variable back into the tl() so everyone doesn't have to change their locale.