Information

Full output of /ess version:
Note, our main servers are running 2.17.2.96 where this is also a present issue (we plan to update in the very near future), more on that below. For sake of testing, I used old versions and latest from Spigot.

28.12 00:38:33 [Server] Server thread/INFO CONSOLE issued server command: /ess version
28.12 00:38:33 [Server] Server thread/INFO Server version: 1.16.4-R0.1-SNAPSHOT git-Spigot-a19903d-5b74714 (MC: 1.16.4)
28.12 00:38:33 [Server] Server thread/INFO EssentialsX version: 2.18.2.0
28.12 00:38:33 [Server] Server thread/INFO LuckPerms version: 5.2.35
28.12 00:38:33 [Server] Server thread/INFO PlaceholderAPI version: 2.10.9
28.12 00:38:33 [Server] Server thread/INFO Citizens version: 2.0.27-SNAPSHOT (build 2170)
28.12 00:38:33 [Server] Server thread/INFO CMI version: 8.7.12.2
28.12 00:38:33 [Server] Server thread/INFO Vault is not installed. Chat and permissions may not work.
28.12 00:38:33 [Server] Server thread/INFO You are running a server with limited API functionality. EssentialsX will still work, but certain features may be disabled.

Server startup log:
I removed the IP Address. Note minimal plugin usage is because this is a test server. This also happens on our main servers (all 6), as well as confirmed happen to other people via the ESSX #support channel

• latest.log

EssentialsX config:
Our main servers are on 2.17.2.96, we do understand this is an incredibly old version, we have full plans to update once our events finish. The last few months of each year we have massive seasonal events and avoid any planned change during this time unless for emergency maintenance/update. For sake of testing, this is an issue on 2.17.2.96 as well as the current version 2.18.2 which I downloaded and used on the test server. Below are the freshly generated configs, no edits other than the testorb kit addition.

• config.yml
• kits.yml

Details

Description:

I'm relaying this bug report from the MOSS EssentialsX #support channel where Evidentsinger14#1 advised me to open an issue and confirmed that this also happens on their server, something discovered during troubleshooting.

• Summary: Enchantments are not placed on firework stars when received either from essentials "give" or essentials "kits" commands
• It does not matter if the console gives them, another plugin (aka console) gives them, or if a player runs the commands
• You however CAN enchant the fireworkstars if you hold the item in game and run the essentials "enchant" command
• If you run "/kitshow" it does display the enchantments, name, lore, amount, etc exactly as defined in config
• There are no errors neither in game nor in the console

This has worked in the past as we have used enchanted fireworkstars as "orbs" given from ESSX kits for years. It's a major piece of our server.

Steps to reproduce:

1. Create a test kit, item: fireworkstar (or firework_star), any amount, any name, any lore
2. Add enchantments, ie unbreaking, efficiency, protection, etc to the kit. Any enchantment, any level, any amount
3. Gather kit in game
4. Copy the items line from your kit(without the dash), open MC, type /give <username> <paste items line> and receive the same result
5. Manually type out /give <username> fireworkstar 1 unbreaking:1 and receive the same result
6. Attempt the same above with other items such as leather_chestplate, armorstand, etc and they WILL receive enchants. I did not exhaustively go through the MC item list and find out if there are other items.

Expected behavior:

• Enchantments placed on items properly as intended

Console stack trace:
N/A

Screenshots:
Command response and items received:

• https://imgur.com/a/MxSCPaG

Confirmed on:

[02:31:58 INFO]: Server version: 1.16.4-R0.1-SNAPSHOT git-Paper-337 (MC: 1.16.4)
[02:31:58 INFO]: EssentialsX version: 2.19.0-dev+50-817585a
[02:31:58 INFO]: Vault version: 1.7.3-b131

Hoping to check in on this, just updated to latest dev build as of today and issue still occurs. Our server functions HEAVILY on the use of firework stars that have enchants and we're having to use extremely tacky bandaid-like work arounds without these :( will appreciate any help or updates for the PR above

Also i want to double check, I browsed the comments of the commits in the above linked PR and it mentions fireworks but seemingly not firework stars?