Type of bug

Other unexpected behaviour

/ess version output

[15:13:20 INFO]: Server version: 1.16.5-R0.1-SNAPSHOT git-Paper-457 (MC: 1.16.5)
[15:13:20 INFO]: EssentialsX version: 2.19.0-dev+60-74131f8
[15:13:20 INFO]: LuckPerms version: 5.2.100
[15:13:20 INFO]: Vault version: 1.7.3-b131
[15:13:20 INFO]: EssentialsXSpawn version: 2.19.0-dev+60-74131f8
[15:13:20 INFO]: EssentialsXChat version: 2.19.0-dev+60-74131f8

Server startup log

https://paste.gg/p/anonymous/34a47a67c9bb410eba08c6edf29bc750

EssentialsX config files

https://paste.gg/p/anonymous/2bc59f18107248b9980813b4c135e5ee

Error log (if applicable)

No response

Bug description

I was experimenting with the trade signs, a noticed that I am not able to right click an empty sign to restock it when the "selling/line 3" is currency. The trade sign functions properly, I had a player test it by using the trade sign to effectively sell me dirt until the sign what out of currency. I then right clicked the empty sign, collected the first, but then upon right clicking more to restock the currency from my balance so people can sell me more dirt, it gives me Error: There is nothing to collect from this trade sign. I do have money in my balance, I have the permissions (am op), and have broken the sign and tried again. I have also tried with no item in hand. I also have reverse the trade on a new sign, such that I am now selling dirt for money, and can confirm that when a sign runs out of items, I am able to restock it from my inventory. The issue only exists when trying to restock the trade sign with currency from my balance. I posted in the discord help channel, and was advised to submit a bug ticket.

Steps to reproduce

1. 2 people online
2. Create trade sign: [trade] / 10 dirt / $5:10
3. Success, 10 dollars taken from my balance (remaining balance: 19990)
4. Have other user right click on sign to complete trade twice (until sign empty), they receive 10 dollars, lose 20 dirt
5. I (sign owner) right click the sign, collect 20 dirt successfully
6. Right click sign again to restock it with currency from my balance, does not work
7. Error: There is nothing to collect from this trade sign

Expected behaviour

For each right click when the sign is empty, I expected it would take 5 dollars from my balance, thereby allowing one more sale of 10 dirt to me from another user to me when that other user right clicks on the sign.

Actual behaviour

The sign is not restocked with currency, and Error: There is nothing to collect from this trade sign is written to chat.

I don't think the "Expected behaviour" you propose is the correct one... Trade signs that buy itens don't need to have a stock on money because it takes the money directly from the owner account. Have you tried selling more dirt even when the sign hasn't any money "in stock". I am able to do that.

But it kept bothering me why would the sign take the initial 10$? Well I think that's the real bug because it makes sense when there is a trade between itens and the sign need an actual stock. However, it doesn't make sense when the trade is between money and items...