EssentialsX

EssentialsX

2M Downloads

seems that ess.getUser is called repeatedly instead of just once.

WarnDa opened this issue ยท 3 comments

commented

Type of bug

Performance issue or memory leak

/ess dump all output

https://essentialsx.net/dump.html?id=5c7e6b350d7b493aa5b163b69dd1d189

Error log (if applicable)

No response

Bug description

I opened an issue on luckperms because I needed to optimise it.
The dev found the issue was the "getcontect" that had performances issue.
He fixed it but he told me

The remaining %s are mostly coming from the EssentialsX context calculators. You could open an issue there for them to track it - problem seems to be that ess.getUser is called repeatedly instead of just once.
I had a quick look but it's not a super strightforward fix without changing their current design.

LuckPerms/LuckPerms#3209 (comment)

I don't know if he is right or not, but I create an issue, we never know :)

Steps to reproduce

LuckPerms/LuckPerms#3209 (comment)

Expected behaviour

Actual behaviour

commented

This would likely be fixed in #4581

commented

I'll try to update tomorrow and tell you, thanks !

commented

It's better thanks !