EssentialsX

EssentialsX

2M Downloads

Command coloring doesn't work with essx disabling commands

JasonHorkles opened this issue ยท 7 comments

commented

Type of bug

Compatibility issue, Other unexpected behaviour

/ess dump all output

https://essentialsx.net/dump.html?id=499a3a0b4f2a44fb9776c469609e5f1b

Error log (if applicable)

No response

Bug description

Disabling commands in the essx config cause other commands' colors to just be white

This bug has been here for almost as long as I can remember, however I just couldn't be bothered to figure out what was causing it until now lol

Steps to reproduce

  1. Install LuckPerms, Vault, and EssentialsX
  2. Type a LuckPerms command, see that it has colors in it (before you press enter)
  3. Add a disabled command to EssX
  4. Reload EssX (or restart the server)
  5. Repeat step 2, but see that it is all white

Expected behaviour

image

Actual behaviour

image

commented

Unable to produce on my end, looks fine

image

commented

What in tarnation, alright to more testing I go

commented

Looks like it must be something in the essx config, as default config doesn't have the problem but mine does

commented

I've updated the issue accordingly

and i now blame josh

commented

Likely an issue with brig mappings not forwarding if you intercept commands via the Bukkit API, will have to take a look

commented

Yep that looks to be the case. Confirmed on 2.20.0-dev+5-d891268.

commented

This is an issue with commodore, LuckPerm's command library. It doesn't use Paper's CommandRegisteredEvent and thus fails to register its brig commands when CraftServer#syncCommands is called. I've pinged luck and let him know, hopefully he'll have it fixed soon.