Shulker boxes can't be added to trade signs if they were ever placed, even if they're empty
oskarkk opened this issue ยท 1 comments
Type of bug
Other unexpected behaviour
/ess dump all output
https://essentialsx.net/dump.html?id=19eaf5c0e31848c6ac263d9ac5b33121
Error log (if applicable)
No response
Bug description
You can't sell shulker boxes using the trade signs if they were ever placed. A new shulker box, which was never placed, doesn't have NBT tag "tag" with "BlockEntityTag". If a shulker box has that tag, it can't be traded, event if it's empty. If you try to place a trade sign, when you only have an used shulker box, you'll get a message that you don't have a shulker box.
The NBT on the top is an empty shulker box that has been placed and mined. NBT on the bottom is a fresh, just crafted shulker box.
Steps to reproduce
- Craft or
/giveyourself a shulker box. - Try to make a
[trade]sign to sell it. It'll work. - Take again a new shulker box, but this time place it somewhere.
- Break it, you don't even have to open it.
- Now try to make a trade sign. You'll get message that you don't have a shulker box.
Expected behaviour
I think that empty shulker boxes should trade just fine. Shulker boxes with items in them shouldn't be allowed to be traded because that would mean losing the items. Maybe there could be a separate error message telling the player that the only shulker box that he has has items in it and can't be traded if it's not empty.
Actual behaviour
Empty shulker boxes that had been placed can't be traded.
