EssentialsDiscord treats 5XX errors as misconfiguration
Vap0r1ze opened this issue ยท 0 comments
Type of bug
Other unexpected behaviour
/ess dump all
output
https://essentialsx.net/dump.html?id=2fbe46c34ee04580834c7716b0c028e2
Error log (if applicable)
https://paste.gg/p/anonymous/65e77e1b66e841b28379775abe28ac54
Bug description
When Discord responds with a 5XX error code, EssentialsDiscord's webhook fails and doesn't attempt to send it again. 5XX errors are server errors, so they should be treated almost like a 429 and re-attempted after some delay.
I also tried /ess reload
after this happened, but console messages still wouldn't send in my chat (I had to restart the spigot server).
Steps to reproduce
The trigger happens outside of the plugin environment, so you can't reproduce unless you're on a build thats calling to a proxy endpoint rather than a discord endpoint and manually responding with a 5xx
Expected behaviour
EssentialsDiscord should reattempt the webhook message
Actual behaviour
EssentialsDiscord stops trying to send webhook messages, even after /ess reload