EssentialsX

EssentialsX

2M Downloads

Failed to get data for custom chart with id permsPlugin

lorenzop opened this issue ยท 3 comments

commented

Type of bug

Compatibility issue, Error in console

/ess dump all output

(https://essentialsx.net/dump.html?id=d74de341ccc14a80b32fd52dca15bebc)

Error log (if applicable)

https://pastebin.com/E6dtRWt7

Bug description

It seems essentials doesn't know how to handle unsupported permissions plugins. I found 2 other issue tickets with the same error, #4892 and #4726 but they were closed and the error never reproduced. I think this is the cause.

Here is a simple fix, however I haven't compiled and tested this, as I don't have gradle. It's a simple fix, just don't return null. I'm also unsure if this will modify the chart in a way that's unwanted, so best to check with the devs before compiling and running this.

lorenzop@97a4a35

Steps to reproduce

Use a custom or less common permissions plugin which is unsupported by EssentialsX.

Expected behaviour

Expect to silently report nothing to bStats, or as in my suggested change, report "other" to bStats.

Actual behaviour

bStats throws an exception due to a custom chart containing a null key.

commented

i'm having this same issue, did you ever find a fix?

commented

Interesting diagnosis, thanks for finding this out. I'm sure you can open a PR for that change, but I'll let a developer respond here to clarify that.

as I don't have gradle

Gradle comes with the repository, just cd into the directory and ./gradlew to use it, I don't know how it works on Windows if you happen to use it though.

commented

I've compiled my fix, but I'll wait for permission before I try it.

edit: Might need to whitelist an "other" option for that pie chart. Learning as I go.

edit: I removed my custom permissions plugin, but am still seeing the null key chart exception, so now I'm questioning what is the real cause of this, and why do very few people see this same problem.