EssentialsX

EssentialsX

Bukkit Plugins
2M Downloads

Clarify commands defined in kits

YanisBft opened this issue · 2 comments

commented

Feature description

Even though kits can contain commands executed when you receive a kit, it's not really clear to have them defined in items list.
I suggest to move commands to a commands list, as shown in the simple example below.

Before:

kits:
  dtools:
    delay: 600
    items:
      - dpickaxe 1 efficiency:1 durability:1 fortune:1 name:&4Gigadrill lore:The_drill_that_&npierces|the_heavens
      - dshovel 1 digspeed:3 name:Dwarf lore:Diggy|Diggy|Hole
      - lhelm 1 color:255,255,255 name:Top_Hat lore:Good_day,_Good_day
      - daxe:780 1
      - /broadcast {USERNAME} just got some fancy tools!

After:

kits:
  dtools:
    delay: 600
    items:
      - dpickaxe 1 efficiency:1 durability:1 fortune:1 name:&4Gigadrill lore:The_drill_that_&npierces|the_heavens
      - dshovel 1 digspeed:3 name:Dwarf lore:Diggy|Diggy|Hole
      - lhelm 1 color:255,255,255 name:Top_Hat lore:Good_day,_Good_day
      - daxe:780 1
    commands:
      - broadcast {USERNAME} just got some fancy tools!

How the feature is useful

Helps to clarify that you can actually define commands, and avoid to rely on a single slash.

commented

The comments at the top of that file are pretty clear about how to add it, but I’ll wait for comments from a higher power before changing status of this.

commented

I'm curious exactly what does this really solve? I don't think it's particularly hard to tell which ones are commands and which are items in the list - commands have a / before them, while items don't.

The other thing is that right now you can be certain that items and commands will be given/run in the order given in the config, which is useful for eg crates plugins that use commands to give special items with custom NBT, but that guarantee falls apart if you split items and commands out. I'd rather not break this behaviour unless it's for a good reason.

  • 👍1