EssentialsX

EssentialsX

2M Downloads

Items go into off hand if inventory is full

JHarris12345 opened this issue ยท 1 comments

commented

Type of bug

Other unexpected behaviour

/ess dump all output

https://essentialsx.net/dump.html?id=42306cf1bc0e4763b56cd0ded029e046

Error log (if applicable)

No response

Bug description

If you do a command that gives you items, it will put the item into your off-hand if your inventory is full. This can be extremely annoying and items should not go into your off hand without choosing to put an item there.

WHY IS THIS AN ISSUE:
To give a scenario: If your inventory is full and you condense items, the items will go into your off-hand and leave the remainder in your inventory. It never used to do this. It used to just drop the items and ignore your off-hand. Where this can become annoying for players is once an item is in their off-hand, if they are going to right click things like open chests etc and click slightly off center, it will place the block instead. As you can imagine, this is very annoying for grindy servers where the meta is fast condensing -> open chest -> deposit items -> back to fast condensing. As people often misclick the chest and then end up placing a block on their chest instead of opening it

Steps to reproduce

  1. /i cobblestone 10000 will put items into your off hand (this is just an easy way to see the issue Im talking about)

HERE IS HOW TO REPLICATE THE ISSUE I DESCRIBED ABOVE:

  1. Fill your inventory with dirt and then 1 stack of emeralds like this image: https://gyazo.com/e015daf50bbae1ce01785d1d9ff9488b
  2. Run /condense
  3. It will put 7 emerald blocks in your off hand as your inventory is full and leave the remaining 1 emerald in your inventory. It never used to do this. In earlier updates, if your inventory was full it would drop the items to the ground and not touch your offhand

Expected behaviour

Essentials should never touch your off hand when giving items (or at least make it configurable)

Actual behaviour

Items go to the off hand

commented

I've updated this to give a lot more info on why this new change can be annoying