EssentialsX

EssentialsX

Bukkit Plugins
2M Downloads

EssentialsDiscordLink mishandles roles with "+" in their name.

MilesBHuff opened this issue · 4 comments

commented

Type of bug

Other unexpected behaviour

Steps to reproduce

  1. Make roles called "pathfinder", "pathfinder+", etc. (https://github.com/SettleScape/server/tree/master/minecraft/plugins/LuckPerms/yaml-storage/groups)
  2. Set those up for EssentialsDiscordLink (https://github.com/SettleScape/server/blob/master/minecraft/plugins/EssentialsDiscordLink/config.yml#L44-L56)

Expected behaviour

Essentials should understand that "+" is an integral part of the role name.

Actual behaviour

[00:22:29] [Server thread/WARN]: [EssentialsDiscordLink] Invalid group pathfinder+++ was provided for role 699859069112156161. The following groups are available: [owner, pathfinder, pathfinder, moderator, tester, monitor, pathfinder, pathfinder, booster, administrator, wanderer, volunteer, donor, wanderer, explorer, settler, traveller, player]
[00:22:29] [Server thread/WARN]: [EssentialsDiscordLink] Invalid group pathfinder++ was provided for role 699859069112156161. The following groups are available: [owner, pathfinder, pathfinder, moderator, tester, monitor, pathfinder, pathfinder, booster, administrator, wanderer, volunteer, donor, wanderer, explorer, settler, traveller, player]
[00:22:29] [Server thread/WARN]: [EssentialsDiscordLink] Invalid group pathfinder+ was provided for role 699859069112156161. The following groups are available: [owner, pathfinder, pathfinder, moderator, tester, monitor, pathfinder, pathfinder, booster, administrator, wanderer, volunteer, donor, wanderer, explorer, settler, traveller, player]
commented

Please try to put the string in quotes e.g "pathfinder+": xyz

commented

Good thinking.
Unfortunately, the log is still showing the same error, even after quoting all instances of /pathfinder\++/ in all my configs.
This indicates that Essentials is probably over-sanitizing the role names somewhere.

commented

This would be luckperms not providing the correct name to vault, it seems to be filtering non-letters. Not much we could do

  • 👍1
commented

Thanks for looking into it, @JRoy -- I'll file an issue with LuckPerms and link back here.
EDIT: Filed. (LuckPerms/LuckPerms#3774)