Infinite duration not working with /potion
RulerOfEternity opened this issue ยท 8 comments
Type of bug
Other unexpected behaviour
/ess dump all output
https://hasteb.in/pYVG3QtNU4Ka9eF
Error log (if applicable)
No response
Bug description
Attempting to use /potion with a duration of -1 (infinite duration) doesn't work, it produces a potion and the effect of which runs out instantly, this isn't how it normally works with potions when you use for instance /give (/minecraft:give @p potion{display:{Name:'[{"text":"Potion"}]'},custom_potion_effects:[{id:speed,duration:-1,amplifier:1}]}
Steps to reproduce
Use for example /potion effect:glowing power:4 duration:-1
Expected behaviour
An infinite duration potion should be produced, photo example:
Actual behaviour
The potion runs out instantly, photo example:
Perhaps instead of just saying a duration -1 that HAS to work for everything, just only provice a duration:infinite solely for the /potion command if that's possible
Oh and I think the /potion command should work with (tipped) arrows too, it makes sense
Thanks for providing a dump. I think as md said, we still need to talk about how this should be exposed (whether or not that is -1 being infinite on versions that support it, or something else).
As JRoy mentioned there's not much we can do without a dump. If you're on 1.20.x this is a different issue to 1.19.x or any older supported version as potions have changed many times throughout the years.
The way potion durations work in vanilla has changed around 1.20.x and it appears there was no attempt to preserve older behaviour for plugins by Spigot. We will need to make a decision about what durations should mean in EssentialsX going forward.
The dump command wasn't working for me so one of the discord moderators told me to copy paste the config instead, I tried again and now it is: https://essentialsx.net/dump.html?id=ac6b188fd82344d5aac6298dc00b53fd
