It seems like Officer chat isn't working as intended. I've included screenshots and a configuration file, as it's probably easier to see it there than in a long-winded explanation.

Ingame
Console
Config

Also, it seems like a faction's leader should be able to see officer chat, as the leader is technically the top officer. I'm able to confirm that leaders currently don't see officer chat.

found the error

http://jenkins.lolnet.co.nz/job/FactionChat/118/

Seems to be all better now. Thanks for the quick fix!

Also, it seems like a faction's leader should be able to see officer chat, as the leader is technically the top officer. I'm able to confirm that leaders currently don't see officer chat.

Regarding that bit, should I open a separate feature request for that?

ummmmmm that is a good question.... Just checking my code..

if (!ChatMode.IsPlayerMutedTarget(myPlayer, player) && (FactionChatAPI.getPlayerRank(player).equals(Config.LeaderRank)
|| FactionChatAPI.getPlayerRank(player).equals(Config.OfficerRank)) && ChatMode.getChatMode(myPlayer).equals("OFFICER")) {

in english: each player is checked to see if they are either an Officer or a leader, however they must have toggled officer chat.

I can't remember why it has to be toggled other than it was requested that way by someone. However if you want I can change that (add something in the config)

Ok, I see the logic there. It would definitely be cool if there was something in the config for that, though. I'd be very greatful to see that added.