Compatibility - ProRecipes (Tripwire Hooks)
Feeriix opened this issue · 25 comments
Still seeing hook recipes with ProRecipes on v0.26.3.
https://snag.gy/bIkhce.jpg
Running PaperSpigot #916
I forgot about this issue, sorry about that.
I don't believe Drepic has gotten around to improving the API. I will contact him about it.
For now, I think your best bet is still to blacklist the hooks.
I added these values and it still shows up, am I doing something wrong?
results:
- ['minecraft:tripwire_hook']
- ['minecraft:tripwire_hook', 'ANY', '{display:{Name:"recipedshapeditem"}}']
Sorry that I didn't respond. I believe this should work:
results:
tripwire hooks: ['minecraft:tripwire_hook']
ProRecipes shaped: ['minecraft:tripwire_hook', 'ANY', '{display:{Name:"recipedshapeditem"}}']
I started working on re-writing FastCraft because there were some fundamental issues with handling recipes from other plugins. I'm changing how it handles recipes so recipes from other plugins are handled the same way they would be if they were crafted in a crafting table by the player. I can't say when I'll finally be able to release the changes, since I've been really busy with schoolwork, but I will make sure that it handles recipes from ProRecipes correctly.
I just released v0.5, which has compatibility support for ProRecipes. I'm unable to test it, as I haven't purchased the plugin, so could you test the compatibility, and report back?
http://i.imgur.com/480lXmY.png
"Crafting" it will give you the tripwire hook and take the crafting items.
But the recipe is correct, just need the name and correct result.
NPE with v0.11
http://pastebin.com/SEt1CA4s
http://i.imgur.com/4p9OhVB.png
Now I can see the custom items, but not their custom names.
Console spam: [FastCraftPlus] Can't find item name: ItemStack{AIR x 0}
http://i.imgur.com/ck5JOA8.png
Other than that, it seems to be working perfectly. Good work!
On some recipes, the tripwire hook is there.
http://i.imgur.com/LgMwG9T.png
The spam messages are disabled in this jar:
FastCraftPlus.zip
Is the tripwire hook a custom recipe? Or does that also happen without ProRecipes?
Thanks. The hooks are shadow copies of the custom items with the same ingredient requirements.
Tested without ProRecipes, and they don't show up.
Okay. I think I have an idea what is happening. I'll give you another jar
to test when I have some free time later, or maybe tomorrow.
On Tue, Apr 5, 2016 at 3:43 PM Feeriix [email protected] wrote:
Thanks. The hooks are shadow copies of the custom items with the same
ingredient requirements.
Tested without ProRecipes, and they don't show up.—
You are receiving this because you commented.Reply to this email directly or view it on GitHub
#13 (comment)
Can you give this a try?
FastCraftPlus.zip
Names are shown correctly but the tripwire hooks are still there.
http://i.imgur.com/8rPhgQM.png
Only shaped recipes are affected.
I just released v0.12. I'm not sure if it solved the problem, but please give it a try.
This jar will print out a debug message in the console when ProRecipes items show up in the UI. Can you show me the output when the duplicate hooks are showing up?
FastCraftPlus.zip
http://pastebin.com/CHVNSgrQ
Could it be a config issue perhaps?
I think I'm seeing the problem. The hook recipes aren't recipes you registered, but for every recipe you create, a hook recipe is also created with the same ingredients. I'm going to contact the dev about it to figure out exactly what's happening, and how to fix it.
The dev of ProRecipes is going to be adding something to the API that will let me hide the tripwire hooks. I'll let you know when I implement the fix.
The developer has been busy with other things. You can try adding tripwire hooks to the blacklist config for now.
