Compatibility issue with ProRecipes
Deathinflames opened this issue ยท 3 comments
Description
I noticed this stack trace in my server logs and while things still seem to work fine as far as i can tell, there apparently is a API issue with FastCraft + ProRecipes.
Reproduction
- Load FastCraft v2.0.3 and ProRecipes v2.1.4 on Spigot 1.12.2.
Output/Files
- Stack Trace: https://pastebin.com/raw/1u6t4P8M
/fcadmin debug
: no output- RELEVANT CONFIGS: N/A
Server Details
- FastCraft Version: v2.0.3
- Server Version: SPIGOT 1.12.2
- RELEVANT PLUGINS: FastCraft + ProRecipes
I can't figure out why you're getting this error just, looking at the ProRecipes source.
I know about 4 months ago, the packages in ProRecipes were moved around:
mcgrizzz/ProRecipes@448cfcb
And then changed back later because it broke its API:
mcgrizzz/ProRecipes@7915159
Could you check in your ProRecipes.jar to see if it contains a me
or mc
folder at its root? If it's me
, then that's what's causing the issue.
I think I found the issue. It looks like he moved the API classes into a .api package in the first commit (a breaking change), but didn't undo it when he fixed the packages in the second commit.
So, FastCraft is looking for
me.mcgrizzz.prorecipes.RecipeAPI
, when it's actually at
me.mcgrizzz.prorecipes.api.RecipeAPI
.
I'll leave a comment over at mcgrizzz/ProRecipes#29 about it, because that seems to be the issue.