FastAsyncVoxelSniper

FastAsyncVoxelSniper

33.4k Downloads

b eb melt error

FETXU opened this issue ยท 10 comments

commented

Server Implementation

Paper

Server Version

1.17.1

Describe the bug

If you try to set /b eb melt with arrow in hand it returns the following error, and only applies /b e melt

Invalid brush parameters! Use the "info" parameter to display parameter info.|

Please see the following image to see the difference between e and eb:
https://user-images.githubusercontent.com/6114858/78985406-fe163d00-7b28-11ea-8195-6b442f3aa91e.png

To Reproduce

  1. Join server with latest FAVS (2.2.2)
  2. Hold arrow in hand
  3. Use command /b eb melt
  4. See the error shown

Expected behaviour

The command /b eb melt should apply the erode brush properly to the tool

Screenshots / Videos

No response

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/daa83070c03c4295b5cf9a79643374cd

Favs Version

FAVS ver 2.2.2

Checklist

Anything else?

Please dm me in Discord for whitlist to our server so you can test if needed :)

Fetxu#6808

commented

Despite the error, that's wrong, the tool is correctlty assigned. The error is caused by the blendball brush not recognizing melt param.
Performing arrow action, blend ball brush and then erode brush are executed (correct behavior?)

commented

Are we sure it is executing both?

Please see the following examples:
https://imgur.com/a/Wg1E5Tn

Guess which one is the one throwing the error.

Imgur
Post with 0 views.
commented

Quick update: I have just realised I am using FAWE 272 (due to clipboard symlinking not working)

I hope this is not a problem.

I tried FAVS 2.0.0 (with FAWE 272) and it applies to the arrow with no error, but when using it fails to do anything and produces the following error:
https://athion.net/ISPaster/paste/view/134705b6d59e455082eb40de3209e2d1

HOWEVER! We have tried FAVS 2.1.1(with FAWE 272) and it has NO in game errors like the original bug BUT runs like the FAVS 2.2.2 ver. In that it does something, but fails to blend the action. Please see the following result from using /b eb melt several times.
https://imgur.com/a/gleOQdC

commented

I tried FAVS 2.0.0 (with FAWE 272) and it applies to the arrow with no error, but when using it fails to do anything and produces the following error:
Recent FAWE isn't compatible with former FAVS versions.

I had just copied old code from 1.13.2 version and it seemed to work, I will take a look.

commented

@FETXU Shoud blendball brush be applied after or before erode brush?

commented

Hmm. Our builder say the blendball should be applied after :) @Aurelien30000

commented

@Aurelien30000 We think it should be erode and then blendball.

However, when testing the erode and blendball brushes on their own we noticed the following issues:
https://gyazo.com/3ffd7e9eeed02a4e20579fe92f62328e

This is us using /b erode and /b e smooth.

It shows that if we reset brush, then use erode it gouges out holes. Then we use e smooth and it smooths, but then back to erode and it no longer gouges, but seems to keep the e smooth behavior.

commented

That's partially expected, once a brush is assigned to a tool, /b e won't reassign it and just prints some info. However there is no quick command to reset preset, gonna add it while fixing the blenderode execution order ;)

commented

@FETXU Fix hopefully applied, can you test this and have your builder take a look? Ty!
FastAsyncVoxelSniper-2.2.3-SNAPSHOT.zip

commented

@Aurelien30000 Looks good so far. Thanks mate :)

I will get our builders to properly test!