FastAsyncWorldEdit

FastAsyncWorldEdit

152k Downloads

Small Text Bug - Wrong UpdateNotification in console

BlockyTheDev opened this issue ยท 2 comments

commented

Server Implementation

Paper

Server Version

1.19.2

Describe the bug

I tried the FastAsyncWorldEdit version attached to the last Github-Release and one maked as Release from Jenkins and both times FAWE prints following line in my server console:

[17:29:00 WARN]: [com.fastasyncworldedit.core.util.UpdateNotification] You are using a snapshot or a custom version of FAWE. This is not an official build distributed via https://www.spigotmc.org/resources/13932/

To Reproduce

  1. Use a FAWE version from a release
  2. Look into console

Expected behaviour

No information about an SNAPSHOT or CUSTOM version, because it isn't one.

Screenshots / Videos

No response

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/c75a209c226542c6bfbf7db4a4278722

Fawe Version

FastAsyncWorldEdit version 2.4.10

Checklist

Anything else?

No response

commented

I am unable to replicate this

commented

I am unable to replicate this

I tried it again with the last version of FAWE in the Github Release, which is linked in the SpigotMC update message, and the problem persists on my side.
image

But i think I found out why it happens after letting the code print out all field values in the class FaweVersion after following code is done:

public FaweVersion(String version, String commit, String date) {

It ends in these values in with the details out of the file fawe.properties located in the release jar of 2.5.0

year: 22
month: 12
day: 11
hash: 224762365
build: 0
semver: [2, 5, 0]
snapshot: false

In the version of the bug report it ends in following values:

year: 22
month: 11
day: 15
hash: 24582660
build: 0
semver: [2, 4, 10]
snapshot: false

As seen in the text above, both build fields end in the value 0 and in the linked code blow there is a if statement, which checks this build field and because it is 0 it prints out the message.

I hope it helps to reproduce/fix it. I think it should be checked for the snapshot field instead of the build.