FastAsyncWorldEdit

FastAsyncWorldEdit

Bukkit Plugins
152k Downloads

Illegal Argument Exception w/ Nova

GrimPlayzs opened this issue ยท 2 comments

commented

Server Implementation

Spigot

Server Version

1.19.4

Describe the bug

When attempting to break blocks with any of the custom items added by Nova a Spigot Modding API causes a exception shown in chat and console.
Screenshot 2023-06-03 213608

To Reproduce

Download Nova and FAWE onto a Spigot server with the Machines addon.
Give yourself any of the custom tools
Break a block

Expected behaviour

I expect no errors to be shown

Screenshots / Videos

No response

Error log (if applicable)

https://gist.github.com/GrimPlayzs/64f80b8b1c38f986c6f1f9a337ee4874

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/edeb6f1821624a148ae7668ab2c397a9

Fawe Version

FastAsyncWorldEdit version 2.6.2-SNAPSHOT-448;048dcaf

Checklist

Anything else?

No response

commented

Issues with third party plugin integrations should be reported to their author(s).

commented

Issues with third party plugin integrations should be reported to their author(s).

I don't really understand how you expect us to fix this on Nova's end, since it's literally a hardcoded if-block:

FastAsyncWorldEdit/worldedit-bukkit/adapters/adapter-1_20/src/main/java/com/sk89q/worldedit/bukkit/adapter/ext/fawe/v1_20_R1/PaperweightAdapter.java

Lines 919 to 924 in d7cc65d

return StringBinaryTag.of(foreign.getAsString());
} else if (foreign instanceof net.minecraft.nbt.EndTag) {
return EndBinaryTag.get();
} else {
throw new IllegalArgumentException("Don't know how to make native " + foreign.getClass().getCanonicalName());
}

and we'd really like to avoid adding runtime patches for third party plugins.