/drain /fillr with water removes random chunks
itinstructor opened this issue ยท 11 comments
Server Implementation
Paper
Server Version
1.20
Describe the bug
Drain any diameter of water in a large expanse, fillr to fill with water, random chunks are missing even in adjoining land mass within the diameter.
This has occurred over the last several versions of FAWE.
This did not occur on 1.19.4. It started happening on 1.20.1. If I run the current FAWE on a 1.19.4 server, the issues still occur.
To Reproduce
A paper 1.21 server, only FAWE and VoxelSniper as plugins. 6 GB of ram, Windows server 2022 or Windows 10. Java Coretto 17, brand new default world.
- Large expanse of water: /drain 100
- /fillr 125
Expected behaviour
The ocean terrain should stay as it was.
Screenshots / Videos
Error log (if applicable)
No response
Fawe Debugpaste
https://athion.net/ISPaster/paste/view/fabf364c284e46169a142c0c8dc8c749
Fawe Version
FastAsyncWorldEdit version 2.6.4-SNAPSHOT-499
Checklist
- I have included a Fawe debugpaste.
- I am using the newest build from https://ci.athion.net/job/FastAsyncWorldEdit/ and the issue still persists.
Anything else?
I appreciate your help.
Do you have an error while doing it? Your fawe debugpaste doesn't show anything where you reproduced it and you have no error log.
I can't really reproduce it with stone (depends on height maybe), I think you mean //fillr water 125, but I saw that the tick limiter blocked physics and created two water holes.
Here is a debugpaste of that (ignore the other plugins as it's a test and not a production server on 1.19.4, latest fawe):
https://athion.net/ISPaster/paste/view/b165a8b4b5294fe9b64b1c6efaac0608
@itinstructor can you temporary turn off the tick limiter in the config and tell me if it still happens?
Turned off tick limiter in new default world.
config.yml
Generic tick limiter (not necessarily WorldEdit related, but useful to stop abuse)
tick-limiter:
Enable the limiter
enabled: false
The interval in ticks
interval: 20
Max falling blocks per interval (per chunk)
falling: 64
Max physics per interval (excluding redstone)
physics-ms: 10
Max item spawns per interval (per chunk)
items: 256
Latest 502 FAWE build.
https://athion.net/ISPaster/paste/view/9094c57d088d47d397c66055e8e734f0
[06:46:27 INFO]: itinstructor[/127.0.0.1:1207] logged in with entity id 1 at ([world]16.5, 71.0, 30.5)
[06:47:11 INFO]: itinstructor issued server command: //drain 125
[06:47:12 INFO]: Using com.sk89q.worldedit.bukkit.adapter.impl.fawe.v1_20_R1.PaperweightStarlightRelighterFactory as relighter factory.
[06:47:21 INFO]: itinstructor issued server command: //fillr water 200
[06:47:32 INFO]: itinstructor issued server command: //drain 100
[06:47:39 INFO]: itinstructor issued server command: //fillr water 200
[06:47:49 INFO]: itinstructor issued server command: //drain 100
[06:48:24 INFO]: itinstructor issued server command: //fillr water 200
[06:49:08 INFO]: itinstructor issued server command: //drain 200
[06:49:20 INFO]: itinstructor issued server command: //fillr water 250
[06:49:29 INFO]: itinstructor issued server command: //drain 200
[06:49:39 INFO]: itinstructor issued server command: //fillr water 250
[06:49:48 INFO]: itinstructor issued server command: //drain 200
[06:50:08 INFO]: itinstructor issued server command: //wand
[06:51:33 INFO]: itinstructor issued server command: //fillr water 300
[06:51:42 INFO]: itinstructor issued server command: //drain 300
[06:51:55 INFO]: itinstructor issued server command: //fillr water 400
[06:52:19 INFO]: itinstructor issued server command: //drain 300
[06:52:36 INFO]: itinstructor issued server command: //fillr water 400
[06:52:54 INFO]: itinstructor issued server command: //drain 400
[06:53:15 INFO]: itinstructor issued server command: //fillr water 450
Same result, random chunks corrupted.
When is that with the corupted chunk happend ?
[06:47:11 INFO]: itinstructor issued server command: //drain 125
[06:47:12 INFO]: Using com.sk89q.worldedit.bukkit.adapter.impl.fawe.v1_20_R1.PaperweightStarlightRelighterFactory as relighter factory.
[06:47:21 INFO]: itinstructor issued server command: //fillr water 200
[06:47:32 INFO]: itinstructor issued server command: //drain 100
[06:47:39 INFO]: itinstructor issued server command: //fillr water 200
[06:47:49 INFO]: itinstructor issued server command: //drain 100
[06:48:24 INFO]: itinstructor issued server command: //fillr water 200
[06:49:08 INFO]: itinstructor issued server command: //drain 200
[06:49:20 INFO]: itinstructor issued server command: //fillr water 250
[06:49:29 INFO]: itinstructor issued server command: //drain 200
[06:49:39 INFO]: itinstructor issued server command: //fillr water 250
[06:49:48 INFO]: itinstructor issued server command: //drain 200
[06:50:08 INFO]: itinstructor issued server command: //wand
[06:51:33 INFO]: itinstructor issued server command: //fillr water 300
[06:51:42 INFO]: itinstructor issued server command: //drain 300
[06:51:55 INFO]: itinstructor issued server command: //fillr water 400
[06:52:19 INFO]: itinstructor issued server command: //drain 300
[06:52:36 INFO]: itinstructor issued server command: //fillr water 400
[06:52:54 INFO]: itinstructor issued server command: //drain 400
[06:53:15 INFO]: itinstructor issued server command: //fillr water 450
I mean i see only thats was executed but not when.
Brand new world.
[08:28:58 INFO]: itinstructor issued server command: //drain 200
[08:28:58 INFO]: Using com.sk89q.worldedit.bukkit.adapter.impl.fawe.v1_20_R1.PaperweightStarlightRelighterFactory as relighter factory.
[08:29:52 INFO]: itinstructor issued server command: //fillr water 225
[08:29:59 INFO]: itinstructor issued server command: //drain 200
Screenshots taken right after these commands.
Looks like I just had to increase the numbers for the diameter and I was able to reproduce it. I found out that both commands do that and the damage can't be undone of the solid blocks. This should be looked over as a next step
After some testing, it appears that FastAsyncWorldEdit-Bukkit-2.6.4-SNAPSHOT-486 works just fine. 487 appears to be where the problem started.