FastAsyncWorldEdit

FastAsyncWorldEdit

152k Downloads

Incompatibiliy with CraftBook 3.10.8;4774-83cfe79's door mechanic

RavvenLord opened this issue · 2 comments

commented

Server Implementation

Paper

Server Version

1.19.4

Describe the bug

When enabling the craftbook door mechanic on my 1.19.4 server with FAWE as a replacement to worldedit, the following exception is thrown.

To Reproduce

Install CraftBook v3.10.8;4774-83cfe79
Install FAWE 2.8.1-SNAPSHOT-574;90d52f3

Enable the door mechanic in craftbook.

I have yet to test this on a clean install, I am not in a position right now to setup a fresh server to test this with.
Craftbook has a large quantity of door schematics that might contain legacy blocks etc, most of them created in 1.15.2.

Expected behaviour

No exception

Screenshots / Videos

No response

Error log (if applicable)

https://paste.gg/p/anonymous/b86bb9a47c924ba0a4df5f5d3068494e

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/ae62c5b636534d29a6bd4394777d19fb

Fawe Version

2.8.1-SNAPSHOT-574;90d52f3

Checklist

Anything else?

No response

commented

Using FAWE + CraftBook with the Door Mechanic enabled seems to work for me:

Task :runServer-1.19.4
Located Paper 1.19.4 build 550 in local cache.
Starting Paper...
Starting org.bukkit.craftbukkit.Main
System Info: Java 17 (OpenJDK 64-Bit Server VM 17.0.8+7) Host: Mac OS X 14.0 (aarch64)
Loading libraries, please wait...
2023-10-05 21:12:24,447 ServerMain WARN Advanced terminal features are not available in this environment
*** Warning, you've not updated in a while! ***
*** Please download a new build as per instructions from https://papermc.io/downloads/paper ***
[21:12:27 INFO]: [STDERR]: You have used the Spigot command line EULA agreement flag.
[21:12:27 INFO]: [STDERR]: By using this setting you are indicating your agreement to Mojang's EULA (https://account.mojang.com/documents/minecraft_eula).
[21:12:27 INFO]: [STDERR]: If you do not agree to the above EULA please stop your server and remove this flag immediately.
[21:12:27 INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[21:12:27 INFO]: Loaded 7 recipes
[21:12:28 INFO]: Starting minecraft server version 1.19.4
[21:12:28 INFO]: Loading properties
[21:12:28 INFO]: This server is running Paper version git-Paper-550 (MC: 1.19.4) (Implementing API version 1.19.4-R0.1-SNAPSHOT) (Git: 483368e on ver/1.19.4)
[21:12:28 INFO]: Using 4 threads for Netty based IO
[21:12:28 INFO]: Server Ping Player Sample Count: 12
[21:12:28 WARN]: [!] The timings profiler has been enabled but has been scheduled for removal from Paper in the future.
We recommend installing the spark profiler as a replacement: https://spark.lucko.me/
For more information please visit: PaperMC/Paper#8948
[21:12:28 INFO]: [ChunkTaskScheduler] Chunk system is using 1 I/O threads, 2 worker threads, and gen parallelism of 2 threads
[21:12:28 INFO]: Default game type: SURVIVAL
[21:12:28 INFO]: Generating keypair
[21:12:28 INFO]: Starting Minecraft server on *:25565
[21:12:28 INFO]: Using default channel type
[21:12:28 INFO]: Paper: Using libdeflate (macOS ARM64 / Apple Silicon) compression from Velocity.
[21:12:28 INFO]: Paper: Using native (macOS ARM64 / Apple Silicon) cipher from Velocity.
[21:12:28 INFO]: [FastAsyncWorldEdit] Loading server plugin FastAsyncWorldEdit v2.7.2-SNAPSHOT
[21:12:29 INFO]: Got request to register class com.sk89q.worldedit.bukkit.BukkitServerInterface with WorldEdit [com.sk89q.worldedit.extension.platform.PlatformManager@7479d930]
[21:12:29 INFO]: [CraftBook] Loading server plugin CraftBook v3.10.8;4774-83cfe79
[21:12:29 INFO]: Server permissions file permissions.yml is empty, ignoring it
[21:12:29 INFO]: [FastAsyncWorldEdit] Enabling FastAsyncWorldEdit v2.7.2-SNAPSHOT
[21:12:29 INFO]: [com.fastasyncworldedit.core.Fawe] LZ4 Compression Binding loaded successfully
[21:12:29 INFO]: [com.fastasyncworldedit.core.Fawe] ZSTD Compression Binding loaded successfully
[21:12:29 INFO]: Registering commands with com.sk89q.worldedit.bukkit.BukkitServerInterface
[21:12:29 INFO]: WEPIF: Using the Bukkit Permissions API.
[21:12:29 INFO]: Using com.sk89q.worldedit.bukkit.adapter.impl.fawe.v1_19_R3.PaperweightFaweAdapter as the Bukkit adapter
[21:12:29 INFO]: Preparing level "world"
[21:12:30 INFO]: Preparing start region for dimension minecraft:overworld
[21:12:30 WARN]: [com.fastasyncworldedit.core.util.UpdateNotification] An update for FastAsyncWorldEdit is available. You are 574 build(s) out of date.
You are running build 0, the latest version is build 574.
Update at https://www.spigotmc.org/resources/13932/
[21:12:30 INFO]: Time elapsed: 133 ms
[21:12:30 INFO]: Preparing start region for dimension minecraft:the_nether
[21:12:30 INFO]: Time elapsed: 72 ms
[21:12:30 INFO]: Preparing start region for dimension minecraft:the_end
[21:12:30 INFO]: Time elapsed: 37 ms
[21:12:30 INFO]: [CraftBook] Enabling CraftBook v3.10.8;4774-83cfe79
[21:12:30 INFO]: [CraftBook] Loading persistent data from YAML!
[21:12:30 INFO]: Running delayed init tasks
[21:12:30 INFO]: Done (2.434s)! For help, type "help"
[21:12:30 INFO]: Timings Reset

Even enabling the mechanic using the command seems to work:

cb enable Door
[21:14:38 INFO]: Sucessfully enabled Door

Do you use legacy numeric block ids somewhere, for example in the mechanisms.yml?
Edit: Obviously you do, I should learn to read 🤦‍♂️ - Please use the namespaces block identifiers (minecraft:oak_door for example). I think we should address the issue either way. To try to reproduce this, may you provide your mechanisms.yml as well?

commented

Sorry for the long wait time, resolved by removing the legacy names.
I'll close this issue as this is now fixed for me. I hope that is fine, incase FAWE wants to look into more parity with WE when loading these legacy ids, I guess a new issue needs to be opened.