FAWE biomes do not get set to a chunk section with only one biomes (i.e. SingleValuePalette)
itinstructor opened this issue · 9 comments
Server Implementation
Paper
Server Version
1.20.2
Describe the bug
A few FAWE updates ago, the Biome brush stopped working.
To Reproduce
- Use the Biome brush, nothing changes
Expected behaviour
The biome normally changes.
Screenshots / Videos
No response
Error log (if applicable)
No response
Favs Debugpaste
https://athion.net/ISPaster/paste/view/d5ad16546cb84950a499b08f749aad62
Favs Version
Favs 3.11
Checklist
- I have included a debugpaste.
- I am using the newest build from https://dev.bukkit.org/projects/favs and the issue still persists.
Anything else?
No response
Hi,
No, logging in and out does not work. Also, If I restart the server, I do not see changes.
Thanks!
Bill
…----------------------------------------------------------------------------------------------------------
William A Loring
Information Technology Instructor | Western Nebraska Community College
MSCIS, MCT, MCSE, MCP, MOS, Security+, Network+, A+ | 1601 E 27th St, Scottsbluff NE 69361
p: 308.635.6163 | e: ***@***.******@***.***> | Scottsbluff Office: Room B7F
Setup an appointment online with www.calendly.com/loringw<http://www.calendly.com/loringw>
www.facebook.com/WNCCITProgram<http://www.facebook.com/WNCCITProgram> “Like us on Facebook to keep up with current IT happenings!”
“If it’s your job to eat a frog, it’s best to do it first thing in the morning.
And if it’s your job to eat two frogs, it’s best to eat the biggest frog first.” Mark Twain
From: Jordan ***@***.***>
Sent: Sunday, June 16, 2024 6:38 AM
To: IntellectualSites/fastasyncvoxelsniper ***@***.***>
Cc: William Loring ***@***.***>; Author ***@***.***>
Subject: Re: [IntellectualSites/fastasyncvoxelsniper] Biome Brush Not working Since a Couple of FAWE updates ago (Issue IntellectualSites/FastAsyncWorldEdit#2790)
Caution: This email originated from outside of WNCC
DO NOT CLICK links or attachments unless you recognize the sender and know the contents are safe.
________________________________
If you relog do you see the changes
—
Reply to this email directly, view it on GitHub<#2790>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AH2JM4T6JVSJ4ZDFV5DCDL3ZHWBJNAVCNFSM6AAAAABJMSASKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZRGUYTSNBWGE>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
Well you are using Purpur 1.20.6 as far as your debugpaste tells us. Any chance you can try this on paper?
Hi,
I just tried it on paper, same results.
Bill
…----------------------------------------------------------------------------------------------------------
William A Loring
Information Technology Instructor | Western Nebraska Community College
MSCIS, MCT, MCSE, MCP, MOS, Security+, Network+, A+ | 1601 E 27th St, Scottsbluff NE 69361
p: 308.635.6163 | e: ***@***.******@***.***> | Scottsbluff Office: Room B7F
Setup an appointment online with www.calendly.com/loringw<http://www.calendly.com/loringw>
www.facebook.com/WNCCITProgram<http://www.facebook.com/WNCCITProgram> “Like us on Facebook to keep up with current IT happenings!”
“If it’s your job to eat a frog, it’s best to do it first thing in the morning.
And if it’s your job to eat two frogs, it’s best to eat the biggest frog first.” Mark Twain
From: OneLiteFeather ***@***.***>
Sent: Sunday, June 16, 2024 6:43 AM
To: IntellectualSites/fastasyncvoxelsniper ***@***.***>
Cc: William Loring ***@***.***>; Author ***@***.***>
Subject: Re: [IntellectualSites/fastasyncvoxelsniper] Biome Brush Not working Since a Couple of FAWE updates ago (Issue IntellectualSites/FastAsyncWorldEdit#2790)
Caution: This email originated from outside of WNCC
DO NOT CLICK links or attachments unless you recognize the sender and know the contents are safe.
________________________________
Well you are using Purpur 1.20.6 as far as your debugpaste tells us. Any chance you can try this on paper?
—
Reply to this email directly, view it on GitHub<#2790>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AH2JM4QWNJUA52HW23IFHG3ZHWB6ZAVCNFSM6AAAAABJMSASKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZRGU2TOOBVGU>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
Hi,
No, it is also when there are more than one biome in a chunk. I paint the biome on not paying attention to the chunks.
Bill
…----------------------------------------------------------------------------------------------------------
William A Loring
Information Technology Instructor | Western Nebraska Community College
MSCIS, MCT, MCSE, MCP, MOS, Security+, Network+, A+ | 1601 E 27th St, Scottsbluff NE 69361
p: 308.635.6163 | e: ***@***.******@***.***> | Scottsbluff Office: Room B7F
Setup an appointment online with www.calendly.com/loringw<http://www.calendly.com/loringw>
www.facebook.com/WNCCITProgram<http://www.facebook.com/WNCCITProgram> “Like us on Facebook to keep up with current IT happenings!”
“If it’s your job to eat a frog, it’s best to do it first thing in the morning.
And if it’s your job to eat two frogs, it’s best to eat the biggest frog first.” Mark Twain
From: Jordan ***@***.***>
Sent: Sunday, June 16, 2024 7:28 AM
To: IntellectualSites/FastAsyncWorldEdit ***@***.***>
Cc: William Loring ***@***.***>; Author ***@***.***>
Subject: Re: [IntellectualSites/FastAsyncWorldEdit] Biome Brush Not working Since a Couple of FAWE updates ago (Issue #2790)
Caution: This email originated from outside of WNCC
DO NOT CLICK links or attachments unless you recognize the sender and know the contents are safe.
________________________________
This is specifically when biomes are set to a chunk that only has one biome.
—
Reply to this email directly, view it on GitHub<#2790 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AH2JM4Q2XQ63IYA3OFJQDJTZHWHGNAVCNFSM6AAAAABJMTL6JOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZRGY2TCOJVGE>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
The chunk packets do not seem to send every time, and also sometimes it doesn't appear changes have been made due to the way minecraft 3D biome noise now works
The issue is with copying SingleValuePalette as it returns itself, meaning if (when) it is resized, it is updating the wrong PalettedContainer (i.e. copy is not clone)