Clobbered block data cannot be undone (sometimes)
minelolpride opened this issue ยท 1 comments
Server Implementation
Paper
Server Version
1.21
Describe the bug
When copying a region with block containing some data (containers, signs, etc), then pasting it such that it overlaps some other blocks with data, running //undo will sometimes not restore the old data, rather wiping it instead.
To Reproduce
This example will use barrels (more convenient for me)
- Build a mass of barrels with stuff inside (Screenshot A shows the setup I used. I had chunk grid visible, but that is irrelevant)
- Copy this region of barrels and paste it over itself. This can be a full overlap or a partial overlap.
- //undo
Now, any barrels that overlapped will have no items.
Expected behaviour
The old data would be restored upon undo, in this case there would still be items in the barrels.
Screenshots / Videos
Full demo video showing replication
https://github.com/user-attachments/assets/bf19986f-a3fd-436e-a501-088e387517b0
Video B (this doesn't always happen...)
https://github.com/user-attachments/assets/a41f7947-5160-4fbd-bb43-43f573a88f2f
Error log (if applicable)
No response
Fawe Debugpaste
https://athion.net/ISPaster/paste/view/471c9a263a2949c1a82447dfc67d3059
Fawe Version
FastAsyncWorldEdit version 2.12.1-SNAPSHOT-952
Checklist
- I have included a Fawe debugpaste.
- I am using the newest build from https://ci.athion.net/job/FastAsyncWorldEdit/ and the issue still persists.
Anything else?
This looks very similar to #2948 that was fixed a bit ago.
I haven't figured out the exact conditions, but have found that this issue does not occur when there's air in the pasted region (see Video B in the screenshot/video section for that)