Switch to EntityPickupItemEvent
SlimeDog opened this issue ยท 4 comments
Spigot 1.12 latest (today)
ExtraHardMode 3.12.1
[09:14:39] [Server thread/WARN]: [ExtraHardMode] "ExtraHardMode v3.12.1" has registered a listener for org.bukkit.event.player.PlayerPickupItemEvent on method "void com.extrahardmode.features.Water.onPlayerPickupItem(org.bukkit.event.player.PlayerPickupItemEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [Diemex, Mitsugaru, Big_Scary, RoboMWM].
No idea. Word is, they took aim at the dupe bug.
UPDATE: Given how others are responding, I guess that's the issue.
In #spigot-dev:
[10:39:10] pokechu22: Re PlayerPickupItemEvent: The message 'but the event is Deprecated. "Server performance will be affected"' is innacurate; should be easy to change it (will make a PR for it)
[11:01:40] MiniDigger: I think that message is worded like that because of the playerchatevent which will have a performance impact if ppl register listeners for it
[11:02:53] pokechu22: But there's actually that whole @Warning annotation system so you can change the message
[11:09:01] pokechu22: OK... so adding an @Warning to it causes plugins to not load at all. Wonderful.
[11:20:16] pokechu22: I'm confused; that doesn't make any sense as @Warning is used elsewhere...
[11:37:18] pokechu22: Still not sure why it's doing that, making a PR anyways
[11:40:00] pokechu22: Done: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/pull-requests/296/overview
In other words, ignore for now. Will see if I have to switch to the new event or not, but I'll wait for them to settle on it. Either way - should have no impact.