Armor weight factor no longer working?
Opened this issue ยท 8 comments
We've recently updated to EHM 3.8.9 and players are reporting that the slowdown you should get while wearing armor no longer functions.
I believe we were previously running 3.8.
Test without any other plugins installed. Another plugin could be canceling its tasks (which happened to me once).
Another player has clarified the issue. If you have the speed buff from a beacon then it removes the weight debuff even after the speed buff is gone; you have to remove and re-wear your armor for it to take effect again.
Tested on a fresh Spigot 1.11.2 server with only the latest EHM plugin. Environment consisted of a beacon with Speed 1 buff and a player in full iron.
To clarify, the weight reduction does appear to be working but there was a misunderstanding of how the bug was manifested.
The weight reduction does occur but there is a delay between when it activates and is removed. For example, you move at full speed before and after putting your armor on for a second or two before it takes affect; and you stay slowed down for a second or two before and after taking the armor off.
Here is a video demonstration with slowdown percentage increased to 95% for exaggeration:
The weight reduction does occur but there is a delay between when it activates and is removed.
Yes that's correct, the armor is checked every 3 seconds. This is because there are no events for when a player puts on armor via shift-rightclick, for example.
Thank you for taking the time to look at this and respond. I will consider your words and provide a pull request if I can think of a better solution.
Would it be appropriate to comment here if I have an implementation question regarding the code which handles this event?