[Bug] Claims do not expire automatically

Question

[Bug] Claims do not expire automatically

Arthuuurr opened this issue 3 years ago · 9 comments

Arthuuurr commented 3 years ago

Observed Behavior

I defined in the config that the claims will be disclaimed after 45 days and they don't, there are 90 days and they are still there

Expected Behavior

That after 45 days the claim is automatically removed

Reproduction steps

I think there are no steps to reproduce, in the "Expiration Days of the claim" option I set it to 45 days and it does not disclaim

Stack trace or error log

No response

Server version

[08:37:51 INFO]: This server is running Paper version git-Paper-145 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: 3ea224d)
You are 71 version(s) behind
Download the new version at: https://papermc.io/downloads
Previous version: git-Paper-406 (MC: 1.17.1)

GriefPrevention version

version griefprevention
[08:38:07 INFO]: GriefPrevention version 16.18-RC1-4-g9e7fb16

Configuration

# Default values are perfect for most servers.  If you want to customize and have a question, look for the answer here first: http://dev.bukkit.org/bukkit-plugins/grief-prevention/pages/setup-and-configuration/

GriefPrevention:
  SeaLevelOverrides:
    world: -1
    world_nether: -1
    world_the_end: -1
  Claims:
    Mode:
      world_nether: Survival
      world_the_end: Survival
      world: Survival
    PreventGlobalMonsterEggs: true
    PreventTheft: true
    ProtectCreatures: true
    PreventButtonsSwitches: true
    LockWoodenDoors: true
    LockTrapDoors: true
    LockFenceGates: true
    EnderPearlsRequireAccessTrust: true
    RaidTriggersRequireBuildTrust: true
    ProtectHorses: true
    ProtectDonkeys: true
    ProtectLlamas: true
    InitialBlocks: 100
    Claim Blocks Accrued Per Hour:
      Default: 1000
    Max Accrued Claim Blocks:
      Default: 10000
    Accrued Idle Threshold: 0
    AccruedIdlePercent: 0
    AbandonReturnRatio: 1.0
    AutomaticNewPlayerClaimsRadius: -1
    AutomaticNewPlayerClaimsRadiusMinimum: 0
    ExtendIntoGroundDistance: 5
    MinimumWidth: 5
    MinimumArea: 100
    MaximumDepth: -65
    InvestigationTool: GOLDEN_AXE
    ModificationTool: GOLDEN_SHOVEL
    Expiration:
      ChestClaimDays: 7
      UnusedClaimDays: 45
      AllClaims:
        DaysInactive: 45
        ExceptWhenOwnerHasTotalClaimBlocks: 10000
        ExceptWhenOwnerHasBonusClaimBlocks: 5000
      AutomaticNatureRestoration:
        SurvivalWorlds: false
    AllowTrappedInAdminClaims: false
    MaximumNumberOfClaimsPerPlayer: 0
    CreationRequiresWorldGuardBuildPermission: true
    VillagerTradingRequiresPermission: true
    CommandsRequiringAccessTrust: /sethome;/esethome;/createhome;/ecreatehome
    DeliverManuals: true
    ManualDeliveryDelaySeconds: 30
    RavagersBreakBlocks: true
    FireSpreadsInClaims: false
    FireDamagesInClaims: false
    LecternReadingRequiresAccessTrust: true
  Spam:
    Enabled: false
    LoginCooldownSeconds: 30
    LoginLogoutNotificationsPerMinute: 5
    ChatSlashCommands: /me;/global;/local
    WhisperSlashCommands: /tell;/pm;/r;/whisper;/msg
    WarningMessage: Please reduce your noise level.  Spammers will be banned.
    BanOffenders: true
    BanMessage: Baneado por spam.
    AllowedIpAddresses: 1.2.3.4; 5.6.7.8
    DeathMessageCooldownSeconds: 120
    Logout Message Delay In Seconds: 0
  PvP:
    RulesEnabledInWorld:
      world: true
      world_nether: true
      world_the_end: true
    ProtectFreshSpawns: true
    PunishLogout: true
    CombatTimeoutSeconds: 15
    AllowCombatItemDrop: false
    BlockedSlashCommands: /home;/vanish;/spawn;/tpa
    ProtectPlayersInLandClaims:
      PlayerOwnedClaims: true
      AdministrativeClaims: true
      AdministrativeSubdivisions: true
    AllowLavaDumpingNearOtherPlayers:
      PvPWorlds: true
      NonPvPWorlds: true
    AllowFlintAndSteelNearOtherPlayers:
      PvPWorlds: true
      NonPvPWorlds: false
    ProtectPetsOutsideLandClaims: false
  Economy:
    ClaimBlocksMaxBonus: 0
    ClaimBlocksPurchaseCost: 0.0
    ClaimBlocksSellValue: 0.0
  ProtectItemsDroppedOnDeath:
    PvPWorlds: true
    NonPvPWorlds: true
  BlockLandClaimExplosions: true
  BlockSurfaceCreeperExplosions: true
  BlockSurfaceOtherExplosions: true
  LimitSkyTrees: true
  LimitTreeGrowth: false
  PistonMovement: CLAIMS_ONLY
  PistonExplosionSound: true
  FireSpreads: false
  FireDestroys: false
  AdminsGetWhispers: true
  AdminsGetSignNotifications: true
  SmartBan: true
  Mute New Players Using Banned Words: true
  MaxPlayersPerIpAddress: 3
  SilenceBans: true
  Siege:
    Worlds: []
    BreakableBlocks:
    - DIRT
    - GRASS_BLOCK
    - GRASS
    - FERN
    - DEAD_BUSH
    - COBBLESTONE
    - GRAVEL
    - SAND
    - GLASS
    - GLASS_PANE
    - OAK_PLANKS
    - SPRUCE_PLANKS
    - BIRCH_PLANKS
    - JUNGLE_PLANKS
    - ACACIA_PLANKS
    - DARK_OAK_PLANKS
    - WHITE_WOOL
    - ORANGE_WOOL
    - MAGENTA_WOOL
    - LIGHT_BLUE_WOOL
    - YELLOW_WOOL
    - LIME_WOOL
    - PINK_WOOL
    - GRAY_WOOL
    - LIGHT_GRAY_WOOL
    - CYAN_WOOL
    - PURPLE_WOOL
    - BLUE_WOOL
    - BROWN_WOOL
    - GREEN_WOOL
    - RED_WOOL
    - BLACK_WOOL
    - SNOW
    DoorsOpenDelayInSeconds: 300
    CooldownEndInMinutes: 60
  EndermenMoveBlocks: false
  SilverfishBreakBlocks: false
  CreaturesTrampleCrops: false
  RabbitsEatCrops: true
  HardModeZombiesBreakDoors: false
  Database:
    URL: ''
    UserName: ''
    Password: ''
  UseBanCommand: false
  BanCommandPattern: ban %name% %reason%
  Advanced:
    fixNegativeClaimblockAmounts: true
    ClaimExpirationCheckRate: 45
    OfflinePlayer_cache_days: 90
  Abridged Logs:
    Days To Keep: 7
    Included Entry Types:
      Social Activity: true
      Suspicious Activity: true
      Administrative Activity: false
      Debug: false
      Muted Chat Messages: false

Plugin list

No response

Running without GriefPrevention

I attempted running the server without GriefPrevention installed.
The problem does not occur when GriefPrevention is removed from the server.

Running with only GriefPrevention

I attempted running only GriefPrevention on the server.
The issue still occurs when GriefPrevention is the only plugin running.

Running on a fresh, clean server installation

I attempted testing for the issue on a new server.
The issue still occurs on a new server.

Using unmodified client

I attempted testing for the issue with the vanilla client.
The issue still occurs when using the vanilla client.

We appreciate you taking the time to fill out a bug report!

I searched for similar issues before submitting this bug report.

Jikoo · Answer 1 · 2022-04-18T15:48:55.000Z

Please post the output of /claimslist ivan265.

Arthuuurr · Answer 2 · 2022-04-18T15:52:34.000Z

Arthuuurr commented 3 years ago

Jikoo · Answer 3 · 2022-04-18T17:20:31.000Z

      AllClaims:
        DaysInactive: 45
        ExceptWhenOwnerHasTotalClaimBlocks: 10000
        ExceptWhenOwnerHasBonusClaimBlocks: 5000

The user has 10000 claim blocks and is exempt from expiration.

Arthuuurr · Answer 4 · 2022-04-18T21:53:34.000Z

I don't understand the answer you gave me, could you do exactly what I have to do please?

Jikoo · Answer 5 · 2022-04-18T22:06:30.000Z

In your configuration, you have claims set to not expire if users have 10,000 claim blocks. The user has 10,000 claim blocks. The user's claims will not expire. If you want everyone's claims to expire, set the number in your config higher.

Arthuuurr · Answer 6 · 2022-04-18T22:16:24.000Z

I mean that I have to put the option like this? Or specifically how do I have to put the option

    All claims:
      Inactive days: 45
      ExceptWhenOwnerHasTotalClaimBlocks: 10000
      ExceptWhenOwnerHasBonusClaimBlocks: 10000

Jikoo · Answer 7 · 2022-04-19T00:57:00.000Z

ExceptWhenOwnerHasTotalClaimBlocks: 10000 means that if they have 10000 claim blocks their claims will not expire. You need to increase that value if you want their claims to expire. 10001 even, it just needs to be larger.

Arthuuurr · Answer 8 · 2022-04-19T11:17:53.000Z

I mean, to see if I'm clear. Just by putting the value 10001 in the ExceptWhenOwnerHasTotalClaimBlocks: option, they would automatically begin to disclaim claims that are more than 45 days old, right?

bigpresh · Answer 9 · 2022-04-19T11:25:17.000Z

I mean, to see if I'm clear. Just by putting the value 10001 in the ExceptWhenOwnerHasTotalClaimBlocks: option, they would automatically begin to disclaim claims that are more than 45 days old, right?

Well, claims that are more than 45 days old and whose owner has less than 10,000 total claim blocks, yes.

I'd say it was already pretty well explained, and is also documented fairly clearly, but in case it's still not clear - the ExceptWhenOwnerHas* settings are intended to allow automatic deletion of claims only for newer players who didn't play for all that long then left the server, but not automatically delete claims of longer-term players who have put a lot of time into their builds on your server and are probably more likely to return in the future and be upset that everything is gone.

So - if you have ExceptWhenOwnerHasTotalClaimBlocks: 10000 set, then automatic expiration only applies to claims of owners who have less than 10,000 total claim blocks; if they have that many (or more), their claims will not be automatically deleted.

The code which checks this exception should be logging an explanatory message for you, too.

If you want to be ruthless and have even claims belonging to players who've played for a long time and accrued a lot of claim blocks be automatically deleted, then you need to set that threshold to a very high number.

Share to