Iris and Grief prevention

Question

Iris and Grief prevention

OctagonMC opened this issue a year ago · 8 comments

OctagonMC commented a year ago

Observed Behavior

I cant use iris and this plugin because it cant find the iris generator world. and it auto deletes it from the config disabling the worlds land claim pls fix asap

Expected Behavior

Claims should enable in worlds reguardless if gp can see it on load. that was a stupid decision to do it how its worked rn.

Reproduction steps

Generate an iris world
load ur prevention plugin
setup land claims to work on the iris world
reboot server and try claiming in the world

Stack trace or error log

No response

Server version

1.20.2

GriefPrevention version

Latest as of 12.26.23

Configuration

# Default values are perfect for most servers.  If you want to customize and have a question, look for the answer here first: http://dev.bukkit.org/bukkit-plugins/grief-prevention/pages/setup-and-configuration/

GriefPrevention:
  SeaLevelOverrides:
    world: -1
    world_nether: -1
    world_the_end: -1
    Tropical: -1
    spawn1: -1
  Claims:
    Mode:
      Tropical: Disabled
      world: Disabled
      spawn1: Disabled
      world_nether: Survival
      world_the_end: Disabled
    PreventGlobalMonsterEggs: true
    PreventTheft: true
    ProtectCreatures: true
    PreventButtonsSwitches: true
    LockWoodenDoors: true
    LockTrapDoors: true
    LockFenceGates: true
    EnderPearlsRequireAccessTrust: true
    RaidTriggersRequireBuildTrust: true
    ProtectHorses: true
    ProtectDonkeys: true
    ProtectLlamas: true
    InitialBlocks: 100
    Claim Blocks Accrued Per Hour:
      Default: 100
    Max Accrued Claim Blocks:
      Default: 900000
    Accrued Idle Threshold: 0
    AccruedIdlePercent: 0
    AbandonReturnRatio: 1.0
    AutomaticNewPlayerClaimsRadius: 4
    AutomaticNewPlayerClaimsRadiusMinimum: 0
    ExtendIntoGroundDistance: 5
    MinimumWidth: 5
    MinimumArea: 100
    MaximumDepth: -2147483648
    InvestigationTool: STICK
    ModificationTool: GOLDEN_SHOVEL
    Expiration:
      ChestClaimDays: 7
      UnusedClaimDays: 14
      AllClaims:
        DaysInactive: 90
        ExceptWhenOwnerHasTotalClaimBlocks: 10000
        ExceptWhenOwnerHasBonusClaimBlocks: 5000
      AutomaticNatureRestoration:
        SurvivalWorlds: false
    AllowTrappedInAdminClaims: false
    MaximumNumberOfClaimsPerPlayer: 0
    CreationRequiresWorldGuardBuildPermission: true
    VillagerTradingRequiresPermission: true
    CommandsRequiringAccessTrust: /sethome
    DeliverManuals: true
    ManualDeliveryDelaySeconds: 30
    RavagersBreakBlocks: true
    FireSpreadsInClaims: false
    FireDamagesInClaims: false
    LecternReadingRequiresAccessTrust: true
  Spam:
    Enabled: false
    LoginCooldownSeconds: 0
    LoginLogoutNotificationsPerMinute: 5
    ChatSlashCommands: /me;/global;/local
    WhisperSlashCommands: /tell;/pm;/r;/whisper;/msg
    WarningMessage: Please reduce your noise level.  Spammers will be banned.
    BanOffenders: false
    BanMessage: Banned for spam.
    AllowedIpAddresses: 1.2.3.4; 5.6.7.8
    DeathMessageCooldownSeconds: 120
    Logout Message Delay In Seconds: 0
  PvP:
    RulesEnabledInWorld:
      world: true
      world_nether: true
      world_the_end: true
      Tropical: true
      spawn1: true
    ProtectFreshSpawns: true
    PunishLogout: false
    CombatTimeoutSeconds: 15
    AllowCombatItemDrop: false
    BlockedSlashCommands: /home;/vanish;/spawn;/tpa
    ProtectPlayersInLandClaims:
      PlayerOwnedClaims: true
      AdministrativeClaims: true
      AdministrativeSubdivisions: true
    AllowLavaDumpingNearOtherPlayers:
      PvPWorlds: true
      NonPvPWorlds: false
    AllowFlintAndSteelNearOtherPlayers:
      PvPWorlds: true
      NonPvPWorlds: false
    ProtectPetsOutsideLandClaims: false
  Economy:
    ClaimBlocksMaxBonus: 0
    ClaimBlocksPurchaseCost: 0.0
    ClaimBlocksSellValue: 0.0
  ProtectItemsDroppedOnDeath:
    PvPWorlds: false
    NonPvPWorlds: true
  BlockLandClaimExplosions: true
  BlockSurfaceCreeperExplosions: true
  BlockSurfaceOtherExplosions: true
  LimitSkyTrees: true
  LimitTreeGrowth: false
  PistonMovement: CLAIMS_ONLY
  PistonExplosionSound: true
  FireSpreads: false
  FireDestroys: false
  AdminsGetWhispers: true
  AdminsGetSignNotifications: true
  VisualizationAntiCheatCompatMode: false
  SmartBan: true
  Mute New Players Using Banned Words: true
  MaxPlayersPerIpAddress: 3
  SilenceBans: true
  Siege:
    Worlds:
    - Survival
    BreakableBlocks:
    - GRASS_BLOCK
    - DIRT
    - COBBLESTONE
    - OAK_PLANKS
    - SPRUCE_PLANKS
    - BIRCH_PLANKS
    - JUNGLE_PLANKS
    - ACACIA_PLANKS
    - DARK_OAK_PLANKS
    - SAND
    - GRAVEL
    - GLASS
    - GRASS
    - FERN
    - DEAD_BUSH
    - WHITE_WOOL
    - ORANGE_WOOL
    - MAGENTA_WOOL
    - LIGHT_BLUE_WOOL
    - YELLOW_WOOL
    - LIME_WOOL
    - PINK_WOOL
    - GRAY_WOOL
    - LIGHT_GRAY_WOOL
    - CYAN_WOOL
    - PURPLE_WOOL
    - BLUE_WOOL
    - BROWN_WOOL
    - GREEN_WOOL
    - RED_WOOL
    - BLACK_WOOL
    - SNOW
    - GLASS_PANE
    DoorsOpenDelayInSeconds: 300
    CooldownEndInMinutes: 60
  EndermenMoveBlocks: false
  SilverfishBreakBlocks: false
  CreaturesTrampleCrops: false
  RabbitsEatCrops: true
  HardModeZombiesBreakDoors: false
  Database:
    URL: ''
    UserName: ''
    Password: ''
  UseBanCommand: false
  BanCommandPattern: ban %name% %reason%
  Advanced:
    fixNegativeClaimblockAmounts: true
    ClaimExpirationCheckRate: 60
    OfflinePlayer_cache_days: 90
  Abridged Logs:
    Days To Keep: 7
    Included Entry Types:
      Social Activity: true
      Suspicious Activity: true
      Administrative Activity: false
      Debug: false
      Muted Chat Messages: false
  ConfigVersion: 1

Plugin list

No

Running without GriefPrevention

I attempted running the server without GriefPrevention installed.
The problem does not occur when GriefPrevention is removed from the server.

Running with only GriefPrevention

I attempted running only GriefPrevention on the server.
The issue still occurs when GriefPrevention is the only plugin running.

Running on a fresh, clean server installation

I attempted testing for the issue on a new server.
The issue still occurs on a new server.

Using unmodified client

I attempted testing for the issue with the vanilla client.
The issue still occurs when using the vanilla client.

We appreciate you taking the time to fill out a bug report!

I searched for similar issues before submitting this bug report.

RoboMWM · Answer 1 · 2024-01-05T20:37:33.000Z

I don't like the decision either. I'd change its behavior but not sure the best way to go about changing that besides adding yet another config option, since I presume some servers rely on it so it doesn't keep ephemeral worlds in the config. The quick fix for now is adding stuff to softdepend, which I'm not opposed to if anyone PRs that for the legacy branch.

OctagonMC · Answer 2 · 2024-01-06T14:55:42.000Z

Personally I think you should just have it read as an error in the config or have it be the last thing loaded Sent from my iPhoneOn Jan 5, 2024, at 3:37 PM, RoboMWM ***@***.***> wrote: I don't like the decision either. I'd change its behavior but not sure the best way to go about changing that besides adding yet another config option, since I presume some servers rely on it so it doesn't keep ephemeral worlds in the config. The quick fix for now is adding stuff to softdepend, which I'm not opposed to if anyone PRs that for the legacy branch. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

OctagonMC · Answer 3 · 2024-01-06T14:55:58.000Z

What is a soft depend for itSent from my iPhoneOn Jan 5, 2024, at 3:37 PM, RoboMWM ***@***.***> wrote: I don't like the decision either. I'd change its behavior but not sure the best way to go about changing that besides adding yet another config option, since I presume some servers rely on it so it doesn't keep ephemeral worlds in the config. The quick fix for now is adding stuff to softdepend, which I'm not opposed to if anyone PRs that for the legacy branch. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

Jikoo · Answer 4 · 2024-01-06T18:20:37.000Z

A soft dependency is a plugin that isn't required but may enable additional functionality, a plugin GP should load after. They're declared in the plugin.yml and are pretty easy to add, but you'd need to know the full name of the plugin including correct capitalization, i.e. "iris" would not work if the plugin's name is "Iris" or "IrisWorldGenerator" or something.

patrick323 · Answer 5 · 2024-12-13T12:05:08.000Z

A soft dependency is a plugin that isn't required but may enable additional functionality, a plugin GP should load after. They're declared in the plugin.yml and are pretty easy to add, but you'd need to know the full name of the plugin including correct capitalization, i.e. "iris" would not work if the plugin's name is "Iris" or "IrisWorldGenerator" or something.

hello, the name of the plugin that is in the iris plugin.yml is
version: 3.4.2-1.19.2-1.21.1
name: Iris
How would I do it here to correctly load both plugins?

Jikoo · Answer 6 · 2024-12-13T16:24:55.000Z

hello, the name of the plugin that is in the iris plugin.yml is version: 3.4.2-1.19.2-1.21.1 name: Iris How would I do it here to correctly load both plugins?

I've submitted a PR to add Iris to GP's softdepend. As a temporary measure, you could add the line

loadbefore: [GriefPrevention]

to Iris' plugin.yml (or, if it already has a loadbefore section, add GP to the list).

patrick323 · Answer 7 · 2024-12-14T00:40:26.000Z

GriefPrevention

It didn't work, I changed plugin.yml in iris java this way but I wasn't successful.

Jikoo · Answer 8 · 2024-12-14T03:44:47.000Z

That should work fine unless Iris explicitly adds its worlds when the server has finished loading, which is something GP can't reasonably expect to handle in its current state. Could you please provide the full startup log with GP and your modified Iris installed? Hopefully that will hint at what's not working.

Share to