Grief Prevention

Grief Prevention

Bukkit Plugins
1M Downloads

Incompatibilty with chat edited by AntiPopup

MrNonno opened this issue · 2 comments

commented

Observed Behavior

when antipopup and griefprevention are installed the asyncplayerchatevent stops working

Expected Behavior

it should not spam the console, i tried deactivating features that require chat but it still appears

Reproduction steps

install griefprevention and antipopup
type in chat
admire the wall of blood in console

Stack trace or error log

No response

Server version

git-Purpur-2101 (MC: 1.20.4)

GriefPrevention version

GriefPrevention version da38fbd

Configuration

AMD Ryzen 7 5000 series - 16GB

Plugin list

AntiPopup, AuthMe, BetterTeams, BlueSlimeCore, ChestSort, Citizens, CombatLogX, CoreProtect, DiscordSRV, Elevator, Essentials, FastAsyncWorldEdit, FastLogin, floodgate, Geyser-Spigot, GMusic, Graves, GriefPrevention, GSit, Hibernate, InventoryRollbackPlus, LuckPerms, OpenInv, PlaceholderAPI, ProtocolLib, ServerListPlus, SkinsRestorer, Slimefun, spark, Vault, ViaBackwards, ViaVersion, WorldGuard

Running without GriefPrevention

  • I attempted running the server without GriefPrevention installed.
  • The problem does not occur when GriefPrevention is removed from the server.

Running with only GriefPrevention

  • I attempted running only GriefPrevention on the server.
  • The issue still occurs when GriefPrevention is the only plugin running.

Running on a fresh, clean server installation

  • I attempted testing for the issue on a new server.
  • The issue still occurs on a new server.

Using unmodified client

  • I attempted testing for the issue with the vanilla client.
  • The issue still occurs when using the vanilla client.

We appreciate you taking the time to fill out a bug report!

  • I searched for similar issues before submitting this bug report.
commented

Providing the stack trace would have been nice, but this is a duplicate of #1984. Technically GP could do better here, but for whatever reason AntiPopup re-calls all chat events it handles with an immutable and empty recipient list after it has already sent the message:
https://github.com/KaspianDev/AntiPopup/blob/dd257dc78432c167349ddc1e4617aa8ac3c2ab2c/main/src/main/java/com/github/kaspiandev/antipopup/listeners/ChatListener.java#L28-L29
Personally, based on the weird behavior there, inclined to advise you to switch to InteractiveChat mentioned in the duplicate issue for removing signing.

commented