/ignoreclaims doesn't let you sit/unsit other players dogs/cats
snurre0 opened this issue · 9 comments
Observed Behavior
/ignoreclaims used to let you sit/unsit other players cats and dogs to be able to move them easily. Not sure when it stopped working but this is either way no longer the case.
When right clicking another players cat/dog without doing /ignoreclaims first, you get the usual "That belongs to ..." message including "To override, use /IgnoreClaims" (This of course depends on what you have in messages.yml).
If you right click another players cat/dog after doing /ignoreclaims, you no longer get the above message in chat, but you can still not sit/unsit the pet, simply nothing happens.
Expected Behavior
You used to be able to sit/unsit other players pets using /ignoreclaims, but that is no longer the case. I think it should be possible to do that still.
Reproduction steps
- Spawn and tame a dog
- Ensure the dog is sitting
- /givepet the dog to another player
- Right click the dog and observe that you can no longer unsit the dog, and you get a message in chat telling you why
- Do /ignoreclaims
- Right click the dog and observer that you can still not unsit the dog, but you no longer get a message about it in chat
Stack trace or error log
No response
Server version
This server is running Paper version git-Paper-435 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: 681bbff)GriefPrevention version
Tested on both GriefPrevention version 16.18.2 and 16.18.2-5-g614cca3 (This is 16.18.3-beta1 from bukkit.org)Configuration
# Default values are perfect for most servers. If you want to customize and have a question, look for the answer here first: http://dev.bukkit.org/bukkit-plugins/grief-prevention/pages/setup-and-configuration/
GriefPrevention:
SeaLevelOverrides:
world: -1
world_nether: -1
world_the_end: -1
Claims:
Mode:
world: Survival
world_the_end: Survival
world_nether: Survival
PreventGlobalMonsterEggs: true
PreventTheft: true
ProtectCreatures: true
PreventButtonsSwitches: true
LockWoodenDoors: true
LockTrapDoors: true
LockFenceGates: true
EnderPearlsRequireAccessTrust: true
RaidTriggersRequireBuildTrust: true
ProtectHorses: true
ProtectDonkeys: true
ProtectLlamas: true
InitialBlocks: 225
Claim Blocks Accrued Per Hour:
Default: 150
Max Accrued Claim Blocks:
Default: 300000
Accrued Idle Threshold: 0
AccruedIdlePercent: 0
AbandonReturnRatio: 1.0
AutomaticNewPlayerClaimsRadius: 4
AutomaticNewPlayerClaimsRadiusMinimum: 0
ExtendIntoGroundDistance: 20
MinimumWidth: 1
MinimumArea: 10
MaximumDepth: -64
InvestigationTool: STICK
ModificationTool: GOLDEN_SHOVEL
Expiration:
ChestClaimDays: 9999999
UnusedClaimDays: 9999999
AllClaims:
DaysInactive: 9999999
ExceptWhenOwnerHasTotalClaimBlocks: 10000
ExceptWhenOwnerHasBonusClaimBlocks: 5000
AutomaticNatureRestoration:
SurvivalWorlds: false
AllowTrappedInAdminClaims: false
MaximumNumberOfClaimsPerPlayer: 0
CreationRequiresWorldGuardBuildPermission: true
VillagerTradingRequiresPermission: true
CommandsRequiringAccessTrust: /sethome;/esethome;/createhome;/ecreatehome
DeliverManuals: true
ManualDeliveryDelaySeconds: 30
RavagersBreakBlocks: true
FireSpreadsInClaims: false
FireDamagesInClaims: false
LecternReadingRequiresAccessTrust: true
Spam:
Enabled: true
LoginCooldownSeconds: 10
LoginLogoutNotificationsPerMinute: 0
ChatSlashCommands: /me;/global;/local;/minecraft:me;/tpa;/suicide
WhisperSlashCommands: ''
WarningMessage: Please reduce your noise level. Spammers will be muted.
BanOffenders: false
BanMessage: Banned for spam.
AllowedIpAddresses: 1.2.3.4; 5.6.7.8
DeathMessageCooldownSeconds: 0
Logout Message Delay In Seconds: 0
PvP:
RulesEnabledInWorld:
world: true
world_nether: true
world_the_end: true
ProtectFreshSpawns: false
PunishLogout: false
CombatTimeoutSeconds: 0
AllowCombatItemDrop: true
BlockedSlashCommands: /home;/vanish;/spawn;/tpa
ProtectPlayersInLandClaims:
PlayerOwnedClaims: false
AdministrativeClaims: false
AdministrativeSubdivisions: false
AllowLavaDumpingNearOtherPlayers:
PvPWorlds: false
NonPvPWorlds: false
AllowFlintAndSteelNearOtherPlayers:
PvPWorlds: false
NonPvPWorlds: false
ProtectPetsOutsideLandClaims: true
Economy:
ClaimBlocksMaxBonus: 0
ClaimBlocksPurchaseCost: 0.0
ClaimBlocksSellValue: 0.0
ProtectItemsDroppedOnDeath:
PvPWorlds: true
NonPvPWorlds: true
BlockLandClaimExplosions: true
BlockSurfaceCreeperExplosions: false
BlockSurfaceOtherExplosions: false
LimitSkyTrees: false
LimitTreeGrowth: false
PistonMovement: EVERYWHERE
PistonExplosionSound: true
FireSpreads: true
FireDestroys: true
AdminsGetWhispers: false
AdminsGetSignNotifications: true
VisualizationAntiCheatCompatMode: false
SmartBan: true
Mute New Players Using Banned Words: true
MaxPlayersPerIpAddress: 5
SilenceBans: true
Siege:
Worlds: []
BreakableBlocks:
- DIRT
- GRASS <-- can't understand this entry, see BukkitDev documentation
- LONG_GRASS <-- can't understand this entry, see BukkitDev documentation
- COBBLESTONE
- GRAVEL
- SAND
- GLASS
- THIN_GLASS <-- can't understand this entry, see BukkitDev documentation
- WOOD <-- can't understand this entry, see BukkitDev documentation
- WOOL <-- can't understand this entry, see BukkitDev documentation
- SNOW
DoorsOpenDelayInSeconds: 300
CooldownEndInMinutes: 60
EndermenMoveBlocks: true
SilverfishBreakBlocks: true
CreaturesTrampleCrops: true
RabbitsEatCrops: true
HardModeZombiesBreakDoors: true
MobProjectilesChangeBlocks: false
Database:
URL: ''
UserName: ''
Password: ''
UseBanCommand: false
BanCommandPattern: ban %name% %reason%
Advanced:
fixNegativeClaimblockAmounts: true
ClaimExpirationCheckRate: 60
OfflinePlayer_cache_days: 365
Abridged Logs:
Days To Keep: 7
Included Entry Types:
Social Activity: true
Suspicious Activity: false
Administrative Activity: true
Debug: false
Muted Chat Messages: true
ConfigVersion: 1Plugin list
No response
Running without GriefPrevention
- I attempted running the server without GriefPrevention installed.
- The problem does not occur when GriefPrevention is removed from the server.
Running with only GriefPrevention
- I attempted running only GriefPrevention on the server.
- The issue still occurs when GriefPrevention is the only plugin running.
Running on a fresh, clean server installation
- I attempted testing for the issue on a new server.
- The issue still occurs on a new server.
Using unmodified client
- I attempted testing for the issue with the vanilla client.
- The issue still occurs when using the vanilla client.
We appreciate you taking the time to fill out a bug report!
- I searched for similar issues before submitting this bug report.
Just briefly looked over the code and there isn't any logic to sit another player's pet. And I don't ever remember this being a feature.
well what im saying is, i'm not even aware that gp lets u control sitting/unsitting another players pet regardless if they're in a claim or not, or regardless if u have that setting enabled or not
Ah okay, I understand what you mean.
Well it used to be a thing that you were able to do, I've done it many many times over 5 years+ (I unfortunately can't remember when it stopped working).
This is also backed up by the message I get in chat when trying to do so: "That belongs to playername until it's given to you with /givepet.
To override, use /ignoreclaims."
That last line of that message doesn't even exist as part of the message defined inside messages.yml, and is only visible for players with the permission for /ignoreclaims. So everything points to this being a feature.
Also since the entire message is not even displayed if right clicking after doing /ignoreclaims.
can you even sit/unsit another player's dog outside of a claim?
This issue is not specific to claims. If you have set "ProtectPetsOutsideLandClaims" to true, this is an issue anywhere.
well what im saying is, i'm not even aware that gp lets u control sitting/unsitting another players pet regardless if they're in a claim or not, or regardless if u have that setting enabled or not
Here maybe?
Here maybe?
Yeah, thats why you're seeing the message even after doing /ignoreclaims
But this isn't for siting/unsitting another player's pet. I decided and looked back several commits, I also looked at BigScary's repo(the original maintainer of GP) and there isn't any change/removal of pet sitting. So unless this was some very limited/temporary feature of GP there's a good chance that you unknowingly had another plugin that let you control someone else's pets.
Here maybe?
Yeah, thats why you're seeing the message even after doing /ignoreclaims
But this isn't for siting/unsitting another player's pet. I decided and looked back several commits, I also looked at BigScary's repo(the original maintainer of GP) and there isn't any change/removal of pet sitting. So unless this was some very limited/temporary feature of GP there's a good chance that you unknowingly had another plugin that let you control someone else's pets.
All right, I will try to investigate this further myself to see if I can figure out why we think this was a feature before(even if it's GP or not).
Just to clarify, I get that entire message in chat including the ignoreclaims part if I haven't done /ignoreclaims before I right click someones pet, but I get nothing at all if I do /ignoreclaims first.
I was so sure this was a thing before, but it seems I was wrong. (Could be a handy feature for server staff though ;) )
I just now went back to Minecraft 1.18 with GP's initial 18.16 release, and it behaves exactly the same there.
Thank you for checking it out for me, and sorry to bother you with all of this!