Inteacting with a Shopkeepers sign shop warns players that they do not have build right in the claim
lerokko opened this issue ยท 3 comments
Observed Behavior
I have an issue with the Shopkeepers plugin. Right clicking a shop sign also sends a message that a player has no permission to build here even though they are not trying to edit the sign, they just right click it to open the shop GUI.
Expected Behavior
If the sign edit event is not successful or canceled by another plugin right away the message should not be sent.
Reproduction steps
- Download Shopkeepers v2.19.0
- Make a claim
- Make a sign shop inside the claim (explained here)
- Try to open the sign shop (right click) with a user that does not have build permission in the claim)
- Observer the message in chat even though no sign editing is being attempted.
Stack trace or error log
No response
Server version
git-Paper-461 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: b600140)
GriefPrevention version
GriefPrevention version 6236d06
Configuration
# Default values are perfect for most servers. If you want to customize and have a question, look for the answer here first: http://dev.bukkit.org/bukkit-plugins/grief-prevention/pages/setup-and-configuration/
GriefPrevention:
SeaLevelOverrides:
world: -1
world_nether: -1
world_the_end: -1
Claims:
Mode:
world_the_end: Survival
world: Survival
world_nether: Survival
PreventGlobalMonsterEggs: true
PreventTheft: true
ProtectCreatures: true
PreventButtonsSwitches: true
LockWoodenDoors: false
LockTrapDoors: true
LockFenceGates: true
EnderPearlsRequireAccessTrust: false
RaidTriggersRequireBuildTrust: true
ProtectHorses: true
ProtectDonkeys: true
ProtectLlamas: true
InitialBlocks: 1024
Claim Blocks Accrued Per Hour:
Default: 256
Max Accrued Claim Blocks:
Default: 10000000
Accrued Idle Threshold: 0
AccruedIdlePercent: 0
AbandonReturnRatio: 1.0
AutomaticNewPlayerClaimsRadius: -1
AutomaticNewPlayerClaimsRadiusMinimum: 0
ExtendIntoGroundDistance: 7
MinimumWidth: 4
MinimumArea: 25
MaximumDepth: -63
InvestigationTool: GOLDEN_AXE
ModificationTool: GOLDEN_SHOVEL
Expiration:
ChestClaimDays: 180
UnusedClaimDays: 180
AllClaims:
DaysInactive: 730
ExceptWhenOwnerHasTotalClaimBlocks: 4096
ExceptWhenOwnerHasBonusClaimBlocks: 4096
AutomaticNatureRestoration:
SurvivalWorlds: false
AllowTrappedInAdminClaims: true
MaximumNumberOfClaimsPerPlayer: 200
CreationRequiresWorldGuardBuildPermission: true
VillagerTradingRequiresPermission: false
CommandsRequiringAccessTrust: /sethome
DeliverManuals: false
ManualDeliveryDelaySeconds: 30
RavagersBreakBlocks: true
FireSpreadsInClaims: false
FireDamagesInClaims: true
LecternReadingRequiresAccessTrust: true
Spam:
Enabled: false
LoginCooldownSeconds: 4
LoginLogoutNotificationsPerMinute: 10
ChatSlashCommands: /me;/global;/local;/afk
WhisperSlashCommands: /tell;/pm;/r;/whisper;/msg
WarningMessage: Please reduce your noise level. This will be removed once you
rank up..
BanOffenders: false
BanMessage: Banned for spam.
AllowedIpAddresses: 1.2.3.4; 5.6.7.8
DeathMessageCooldownSeconds: 90
Logout Message Delay In Seconds: 0
PvP:
RulesEnabledInWorld:
world: true
world_nether: true
world_the_end: true
ProtectFreshSpawns: true
PunishLogout: false
CombatTimeoutSeconds: 0
AllowCombatItemDrop: true
BlockedSlashCommands: /home;/vanish;/spawn;/tpa;/spec
ProtectPlayersInLandClaims:
PlayerOwnedClaims: false
AdministrativeClaims: false
AdministrativeSubdivisions: false
AllowLavaDumpingNearOtherPlayers:
PvPWorlds: true
NonPvPWorlds: false
AllowFlintAndSteelNearOtherPlayers:
PvPWorlds: true
NonPvPWorlds: false
ProtectPetsOutsideLandClaims: false
Economy:
ClaimBlocksMaxBonus: 0
ClaimBlocksPurchaseCost: 0.0
ClaimBlocksSellValue: 0.0
ProtectItemsDroppedOnDeath:
PvPWorlds: false
NonPvPWorlds: false
BlockLandClaimExplosions: true
BlockSurfaceCreeperExplosions: true
BlockSurfaceOtherExplosions: false
LimitSkyTrees: false
LimitTreeGrowth: false
PistonMovement: IGNORED
PistonExplosionSound: true
FireSpreads: true
FireDestroys: true
AdminsGetWhispers: true
AdminsGetSignNotifications: true
VisualizationAntiCheatCompatMode: false
SmartBan: true
Mute New Players Using Banned Words: false
MaxPlayersPerIpAddress: 4
SilenceBans: true
Siege:
Worlds: []
BreakableBlocks:
- DIRT
- GRASS <-- can't understand this entry, see BukkitDev documentation
- COBBLESTONE
- GRAVEL
- SAND
- GLASS
- SNOW
DoorsOpenDelayInSeconds: 300
CooldownEndInMinutes: 60
EndermenMoveBlocks: false
SilverfishBreakBlocks: true
CreaturesTrampleCrops: true
RabbitsEatCrops: false
HardModeZombiesBreakDoors: true
Database:
URL: ''
UserName: ''
Password: ''
UseBanCommand: false
BanCommandPattern: ban %name% %reason%
Advanced:
fixNegativeClaimblockAmounts: true
ClaimExpirationCheckRate: 30
OfflinePlayer_cache_days: 1825
Abridged Logs:
Days To Keep: 30
Included Entry Types:
Social Activity: true
Suspicious Activity: true
Administrative Activity: false
Debug: false
Muted Chat Messages: false
ConfigVersion: 1
Plugin list
No response
Running without GriefPrevention
- I attempted running the server without GriefPrevention installed.
- The problem does not occur when GriefPrevention is removed from the server.
Running with only GriefPrevention
- I attempted running only GriefPrevention on the server.
- The issue still occurs when GriefPrevention is the only plugin running.
Running on a fresh, clean server installation
- I attempted testing for the issue on a new server.
- The issue still occurs on a new server.
Using unmodified client
- I attempted testing for the issue with the vanilla client.
- The issue still occurs when using the vanilla client.
We appreciate you taking the time to fill out a bug report!
- I searched for similar issues before submitting this bug report.
I am an idiot. I thought I already updated to the latest but I never pushed the changes. It works on the latest GP version.
Sorry for the noise.
Not a problem, thanks for letting us know! Glad to hear this is fixed and is useful for those who may search for this same issue.