Grief Prevention

Grief Prevention

Bukkit Plugins
1M Downloads

ItemsAdder and GriefPrevention bug

SrMonsterYT opened this issue ยท 2 comments

commented

Observed Behavior

it is possible to break furnishings that are made with item-display GriefPrevention is not protecting them

report: PluginBugs/Issues-ItemsAdder#4234 (comment)

Expected Behavior

...

Reproduction steps

break an ItemsAdder protected furniture

Stack trace or error log

No response

Server version

Paper version 1.20.6-151-ver/1.20.6@a4f0f5c

GriefPrevention version

GriefPrevention v16.18.1-48-g6884bdf

Configuration

https://mclo.gs/69VYZ0y

Plugin list

No response

Running without GriefPrevention

  • I attempted running the server without GriefPrevention installed.
  • The problem does not occur when GriefPrevention is removed from the server.

Running with only GriefPrevention

  • I attempted running only GriefPrevention on the server.
  • The issue still occurs when GriefPrevention is the only plugin running.

Running on a fresh, clean server installation

  • I attempted testing for the issue on a new server.
  • The issue still occurs on a new server.

Using unmodified client

  • I attempted testing for the issue with the vanilla client.
  • The issue still occurs when using the vanilla client.

We appreciate you taking the time to fill out a bug report!

  • I searched for similar issues before submitting this bug report.
commented

Item displays don't have hitboxes and can't be interacted with. Are they layering an interaction entity over it or something?
Unfortunately I believe that would be in the realm of a compatibility addon. GP's simplified trust system makes edge cases like this hard - interaction entities would be expected to function through protections in a spawn area, for example.

If they are manually calling an event for an item display I think handling it in base GP would be fine.

/e: I just re-watched the video, and it looks like there is no interaction entity involved. The interaction goes straight through the entity and hits the block behind it and there's no hitbox visible despite them having hitboxes enabled. If you could confirm, I'll make relevant PRs to add item displays to the trust list.

commented

Item displays don't have hitboxes and can't be interacted with. Are they layering an interaction entity over it or something? Unfortunately I believe that would be in the realm of a compatibility addon. GP's simplified trust system makes edge cases like this hard - interaction entities would be expected to function through protections in a spawn area, for example.

If they are manually calling an event for an item display I think handling it in base GP would be fine.

/e: I just re-watched the video, and it looks like there is no interaction entity involved. The interaction goes straight through the entity and hits the block behind it and there's no hitbox visible despite them having hitboxes enabled. If you could confirm, I'll make relevant PRs to add item displays to the trust list.

sorry I don't understand how they work, but I know that the owner of the plugin managed to apply a protection and corrected it somehow, now how he did it I can't tell you sorry, I'll mention it here @LoneDev6