Gringotts

Gringotts

53.6k Downloads

Virtual Accounts

jastice opened this issue ยท 6 comments

commented
  • Support virtual accounts, which are not bound to physical representation of money.
  • Config option to enable virtual accounts for unknown account types
  • Config options to make player, faction, town vaults etc virtual
commented

I guess the question I should ask, then, is how can I help, and where should I look in the code?

commented

Thanks for asking! The things to do would be:

  • make an AccountHolderProvider for virtual accounts and add it to the providers with lowest precedence
  • abstract or subclass GringottsAccount to support the purely virtual behavior
  • make the provider use the virtual account
commented

Alright, so I'm looking through the org.gestern.gringotts.accountholder package and I've identified the AccountHolderFactory where the providers are linked. I'm wondering if you prefer doing this differently from how I would. I was going to suggest I create a new class called VirtualAccountHolder that implements in the same way that PlayerAccountHolder does, but I'm not sure that's necessary. PlayerAccountHolder looks like it currently supports everything that a virtual account would need, so the benefit of another class would, unless I'm wrong, be merely for aesthetic and organizational purposes?

commented

PlayerAccountHolder is/should be tied to how Minecraft and Bukkit represent a player, that is, an OfflinePlayer object, which should contain a valid player UUID -- at least, Gringotts works under this assumption. Furthermore, player accounts should behave differently from purely virtual accounts.

By the way, do you have a preferred instant messenger? Makes it easier to discuss things.

commented

Well, I'd prefer to use IRC, but I don't think you guys have a channel, do you? If not that, then I can download Pidgin, which supports most chat protocols. What do most of you use?

commented

That's cool, we're on #minecraftwars on freenode