Griswold – NPCs repair your items

Griswold – NPCs repair your items

25.7k Downloads

Dont repair unbreakable item

prozhong opened this issue · 11 comments

commented

https://www.spigotmc.org/wiki/custom-item-models-in-1-9-and-up/

https://hub.spigotmc.org/javadocs/spigot/org/bukkit/inventory/meta/ItemMeta.html#setUnbreakable(boolean)

some plugins introduce some items which are unbreakable, if repaired their custom model will change.

Could you please add an option to disable repairing unbreakable item?

commented

Hey there, I'll look into that.

commented

https://github.com/toxuin/Griswold/blob/master/src/com/github/toxuin/griswold/Interactor.java#L339
This line of code won't be reached, unless that repairman's RepairerType is undefined

commented

Smh, didn't even pay attention.
Try this one

commented

Hey, test this out: https://github.com/toxuin/Griswold/releases/tag/v0.078
Haven't published this anywhere yet, lemme know if that works or not.

commented

sorry for my late reply
with version 0.079 I can still repair my durability = 10 & unbreakable custom model weapon
maybe could you consider fix it like this ?prozhong@38a5bdc
just do more check if config has option like 'dont-repair-and-enchant-unbreakable = true'

commented

@prozhong I'm waiting for some feedback from you, if that works I'm gonna upload this to bukkitdev+spigot

commented

use RPGitems to create this kind of item
see NyaaCat/RPGItems-reloaded#197

commented

So does it work for you with prozhong@38a5bdc? Have you tested your own build?

commented
commented

Hi all.

This should now be fixed in release 0.079 along with other stuff.

Release 0.079

@prozhong, since you're our beta-tester here now (🥇), please test this release in your setup and let us know. I've tested it on my local installation and it seems to work, but my setup is probably much simpler than yours anyways.

Please let us know if you find any more bugs or have any comments/suggestions/wishes.

commented

griswold
@toxuin @Haarolean Release 0.079 fixs this issue, thanks

https://imgur.com/a/7nNsd
this is my temp fix, but yours are better, I think
👍