This method has 2 other overrides that do not use NMS, check to see if the above is still being used and deprecate if not. If it is, see if it can be migrated to the below methods instead

Only 2 occurrences: https://github.com/search?q=repo%3AHarryPotterSpells%2FHarryPotterSpells%20FireworkEffectPlayer%20&type=code

1. HarryPotterSpells/src/com/hpspells/core/SpellTargeter.java

   Line 125 in c2bfd4f

   FireworkEffectPlayer.playFirework(loc.getWorld(), loc, effect);

   
   This will need to be updated to use a one of the non NMS overrides

2. HarryPotterSpells/src/com/hpspells/core/spell/HomenumRevelio.java

   Line 34 in c2bfd4f

   FireworkEffectPlayer.playFirework(entity.getLocation(), effect);

   
   This firework effect is fine.

Turns out the specific register method (below) that uses the FireworkEffectPlayer.playFirework with NMS solution isn't actually being used anywhere now, we can probably deprecate