HarryPotterSpells

HarryPotterSpells

59.3k Downloads

[HPS] Paper breaking NMS code since 1.20.5

jacklin213 opened this issue ยท 0 comments

commented

Describe the bug
As called out in PaperMC internals

As of 1.20.5, the versioned relocation of the CraftBukkit package was removed and CraftBukkit packages are now located in org.bukkit.craftbukkit and not in org.bukkit.craftbukkit..

This ends up breaking anything that uses our SVPBypass class which relies on NMS: https://github.com/search?q=repo%3AHarryPotterSpells%2FHarryPotterSpells%20SVPBypass&type=code such and HPS Commands, FireworkEffects and item glow

Actions

  • Figure out all the use cases of SVPBypass and update section below
  • Find non NMS alternatives
  • If we have to use NMS, our plugin is SpigotMC first so we won't be able to utilize the paperweight-userdev Gradle plugin as suggested in the documentation, thus we need to find someway to continue accessing org.bukkit.craftbukkit instead of org.bukkit.craftbukkit.<version> in SVPBypass if Server is variant of PaperMC

SVPBypass Use cases