BUG: Custom-added potions being auto-added to shops
MardMallard opened this issue ยท 2 comments
I have several custom potions which I have used the /additem command to add to the HyperConomy database. Buying and selling these items works well, however when the plugin is disabled+enabled or on a server restart, all of my custom potions are automatically added to every server shop on the server. This only happens with potions that /additem has been used on - it doesn't seem to affect other items.
Some of them can be removed, but for most of them using /ss ban [name] results in a message claiming that the item is already banned from the shop. This happens with imatinib, local anaesthetic and potassium cyanide.
It would be ideal if these items weren't added to server shops on restart.
For reproduction purposes the items I have added to the database are:
Imatinib: Bungling Potion (data value 23)
Local_Anaesthetic: Debonair Potion (data value 31)
Potassium_Cyanide: Stinky Potion (data value 61)
^^ Items above can not be banned from any server shop. Items below, can.
Aspirin: Mundane Potion (data value 8192, with lore name "Aspirin" and lore description "Good ol' aspirin."
Escitalopram: Thick Potion (data value 32, with lore name "Escitalopram" and lore description "It can treat depression and generalized anxiety disorder."
Cydazine: Sparkling Potion (data value 47, with lore name "Cydazine" and lore description "Immunosuppressants. Simple enough."
This may be fixed in the latest build. 1.9 has changed the way potions work. Also, due to the nature of how server shops work, it will be necessary to ban the items from shops when adding new ones if they're in the same economy that you added the items to. Server shops are more or less directly tied to the economy they're in, meaning they have access to all items in that economy. If you place some of your shops in a separate economy they will not be affected by adding new items.
Banning the items from server shops doesn't work in the long term, because they are unbanned the next time the plugin is reloaded or the server is restarted. Some potions also can't be banned as I get the message stating that it is already banned. It's mostly an issue because I have seperate server shops for different types of items (eg. a minerals shop, a plants shop, a tools shop, etc.)