Ever thought of checking the permission before executing a command?

Question

Ever thought of checking the permission before executing a command?

yannicklamprecht opened this issue 4 years ago · 3 comments

yannicklamprecht commented 4 years ago

https://github.com/zDevelopers/zLib/blob/master/src/main/java/fr/zcraft/zlib/components/commands/CommandGroup.java#L147-L178

ImageOnMap has no Permission check due this bug.

yannicklamprecht · Answer 1 · 2020-08-11T13:40:04.000Z

Yes but we already test that in the Command.execute() method—canExecute checks the permissions and all. Are you sure there is a bug on the zLib side there?

https://github.com/zDevelopers/zLib/blob/cb43ab335154738947d647b7d3c9e3a84996b180/src/main/java/fr/zcraft/zlib/components/commands/Command.java#L165-L166

Then it is a bug in here. https://github.com/zDevelopers/ImageOnMap version 4.0 does allow creating new maps without having the needed permissions. So it is clearly a bug.

AmauryCarrade · Answer 2 · 2020-08-11T13:41:52.000Z

Okay. I'll check that and meanwhile, move this issue to the right repository.

AmauryCarrade · Answer 3 · 2020-08-11T13:04:18.000Z

Yes but we already test that in the Command.execute() method—canExecute checks the permissions and all. Are you sure there is a bug on the zLib side there?

https://github.com/zDevelopers/zLib/blob/cb43ab335154738947d647b7d3c9e3a84996b180/src/main/java/fr/zcraft/zlib/components/commands/Command.java#L165-L166

Share to